Skip to content

Commit a256d34

Browse files
committed
revert unrelated changes
Signed-off-by: alperozturk <alper_ozturk@proton.me>
1 parent 90a4eff commit a256d34

File tree

3 files changed

+11
-32
lines changed

3 files changed

+11
-32
lines changed

app/src/main/java/it/niedermann/owncloud/notes/persistence/CapabilitiesClient.java

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,16 @@
1313
import androidx.annotation.Nullable;
1414
import androidx.annotation.WorkerThread;
1515

16-
import com.nextcloud.android.sso.api.EmptyResponse;
16+
import com.nextcloud.android.sso.api.ParsedResponse;
1717
import com.nextcloud.android.sso.model.SingleSignOnAccount;
1818

19-
import java.util.Objects;
19+
import java.util.Map;
2020

21+
import it.niedermann.owncloud.notes.persistence.sync.OcsAPI;
2122
import it.niedermann.owncloud.notes.shared.model.Capabilities;
23+
import it.niedermann.owncloud.notes.shared.model.OcsResponse;
24+
import it.niedermann.owncloud.notes.shared.model.OcsUser;
25+
import retrofit2.Response;
2226

2327
@WorkerThread
2428
public class CapabilitiesClient {
@@ -30,8 +34,6 @@ public class CapabilitiesClient {
3034
@WorkerThread
3135
public static Capabilities getCapabilities(@NonNull Context context, @NonNull SingleSignOnAccount ssoAccount, @Nullable String lastETag, @NonNull ApiProvider apiProvider) throws Throwable {
3236
final var ocsAPI = apiProvider.getOcsAPI(context, ssoAccount);
33-
final var repository = NotesRepository.getInstance(context);
34-
3537
try {
3638
final var response = ocsAPI.getCapabilities(lastETag).blockingSingle();
3739
final var capabilities = response.getResponse().ocs.data;
@@ -42,20 +44,16 @@ public static Capabilities getCapabilities(@NonNull Context context, @NonNull Si
4244
Log.w(TAG, "Response headers of capabilities are null");
4345
}
4446

47+
final var repository = NotesRepository.getInstance(context);
4548
repository.insertCapabilities(capabilities);
4649

4750
return capabilities;
48-
} catch (Throwable t) {
49-
if (t instanceof ClassCastException castException && Objects.requireNonNull(castException.getMessage()).contains(EmptyResponse.class.getSimpleName())) {
50-
Log.d(TAG, "Server returned empty response - Notes not modified.");
51-
return repository.getCapabilities();
52-
}
53-
54-
final var cause = t.getCause();
51+
} catch (RuntimeException e) {
52+
final var cause = e.getCause();
5553
if (cause != null) {
5654
throw cause;
5755
} else {
58-
throw t;
56+
throw e;
5957
}
6058
}
6159
}

app/src/main/java/it/niedermann/owncloud/notes/persistence/NotesServerSyncTask.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import androidx.annotation.NonNull;
1919

2020
import com.nextcloud.android.sso.AccountImporter;
21-
import com.nextcloud.android.sso.api.EmptyResponse;
2221
import com.nextcloud.android.sso.exceptions.NextcloudApiNotRespondingException;
2322
import com.nextcloud.android.sso.exceptions.NextcloudFilesAppAccountNotFoundException;
2423
import com.nextcloud.android.sso.exceptions.NextcloudHttpRequestFailedException;
@@ -34,7 +33,6 @@
3433
import java.util.HashSet;
3534
import java.util.List;
3635
import java.util.Map;
37-
import java.util.Objects;
3836

3937
import it.niedermann.owncloud.notes.BuildConfig;
4038
import it.niedermann.owncloud.notes.persistence.entity.Account;
@@ -282,11 +280,6 @@ private boolean pullRemoteChanges() {
282280
return true;
283281
} catch (Throwable t) {
284282
final Throwable cause = t.getCause();
285-
if (t instanceof ClassCastException castException && Objects.requireNonNull(castException.getMessage()).contains(EmptyResponse.class.getSimpleName())) {
286-
Log.d(TAG, "Server returned empty response - Notes not modified.");
287-
return true;
288-
}
289-
290283
if (t.getClass() == RuntimeException.class && cause != null) {
291284
if (cause.getClass() == NextcloudHttpRequestFailedException.class || cause instanceof NextcloudHttpRequestFailedException) {
292285
final NextcloudHttpRequestFailedException httpException = (NextcloudHttpRequestFailedException) cause;

app/src/main/java/it/niedermann/owncloud/notes/persistence/sync/CapabilitiesDeserializer.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
import com.google.gson.JsonParseException;
1818

1919
import java.lang.reflect.Type;
20-
import java.util.ArrayList;
21-
import java.util.List;
2220

2321
import it.niedermann.android.util.ColorUtil;
2422
import it.niedermann.owncloud.notes.shared.model.Capabilities;
@@ -91,19 +89,9 @@ public Capabilities deserialize(JsonElement json, Type typeOfT, JsonDeserializat
9189
if (capabilities.has(CAPABILITIES_NOTES)) {
9290
final var notes = capabilities.getAsJsonObject(CAPABILITIES_NOTES);
9391
if (notes.has(CAPABILITIES_NOTES_API_VERSION)) {
94-
final var apiVersionElem = notes.get(CAPABILITIES_NOTES_API_VERSION);
95-
if (apiVersionElem.isJsonArray()) {
96-
List<String> versions = new ArrayList<>();
97-
for (JsonElement e : apiVersionElem.getAsJsonArray()) {
98-
versions.add(e.getAsString());
99-
}
100-
response.setApiVersion(String.join(",", versions));
101-
} else if (apiVersionElem.isJsonPrimitive()) {
102-
response.setApiVersion(apiVersionElem.getAsString());
103-
}
92+
response.setApiVersion(notes.get(CAPABILITIES_NOTES_API_VERSION).toString());
10493
}
10594
}
106-
10795
if (capabilities.has(CAPABILITIES_THEMING)) {
10896
final var theming = capabilities.getAsJsonObject(CAPABILITIES_THEMING);
10997
if (theming.has(CAPABILITIES_THEMING_COLOR)) {

0 commit comments

Comments
 (0)