-
Notifications
You must be signed in to change notification settings - Fork 19
feat(chart,jobs): Adding resources configuration blocks for AdmissionWebhooks #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbudziwojskiNR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! We would also need helm unit tests added that covers this new functionality.
Co-authored-by: Daniel Budziwojski <dbudziwojski@newrelic.com>
Co-authored-by: Daniel Budziwojski <dbudziwojski@newrelic.com>
…injection into chart-job-resources
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
=======================================
Coverage 51.93% 51.93%
=======================================
Files 3 3
Lines 233 233
=======================================
Hits 121 121
Misses 107 107
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # CHANGELOG.md
|
Hi @tviaud! Thanks for your patience, merging this in. |
Description
This pull request adds support for configuring resource requests and limits for the
admission-createandadmission-patchKubernetes jobs in thenri-metadata-injectionHelm chart.Type of change
Checklist: