Skip to content

Commit 28f6b8f

Browse files
committed
merge master
2 parents ef4872c + 27a9b51 commit 28f6b8f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ dependencies {
5151
#### Implement
5252
1. Implement the `TracingRequestHandler` interface as shown in the [example](#example-usage), defining the Lambda function input and output types that your function requires.
5353
2. Override the `doHandleRequest` method from the interface and execute your function logic within it. *Note:* If you are refactoring a pre-existing Lambda handler to take advantage of this SDK's tracing request handler make sure that it overrides `doHandleRequest` but not `handleRequest`.
54-
3. Register the OpenTracing Tracer of your choice.
54+
3. Register the OpenTracing Tracer of your choice (e.g. New Relic, Jaeger, etc).
5555
4. See Amazon's documentation on [creating a ZIP deployment package for a Java Lambda function](https://docs.aws.amazon.com/lambda/latest/dg/create-deployment-pkg-zip-java.html)
5656
5. When creating your Lambda function in AWS Lambda console the handler for the given example would be entered as `com.handler.example.MyLambdaHandler::handleRequest` or just `com.handler.example.MyLambdaHandler`, the latter of which will use `handleRequest` as the handler method by default. *Note:* `handleRequest` is used as the handler entry point as it will call `doHandleRequest`.
5757

@@ -74,7 +74,7 @@ import java.util.Map;
7474
*/
7575
public class MyLambdaHandler implements TracingRequestHandler<Map<String, Object>, String> {
7676
static {
77-
// TODO Obtain an instance of the OpenTracing Tracer of your choice
77+
// Obtain an instance of the OpenTracing Tracer of your choice
7878
Tracer tracer = new CustomTracer(...);
7979
// Register your tracer as the Global Tracer
8080
GlobalTracer.register(tracer);
@@ -89,7 +89,7 @@ public class MyLambdaHandler implements TracingRequestHandler<Map<String, Object
8989
*/
9090
@Override
9191
public String doHandleRequest(Map<String, Object> input, Context context) {
92-
// TODO Your function logic here
92+
// Your function logic here
9393
return "Lambda Function output";
9494
}
9595
}
@@ -122,7 +122,7 @@ Run the following gradle task:
122122
```
123123

124124
### Contributing
125-
Full details are available in our CONTRIBUTING file;
125+
Full details are available in our [CONTRIBUTING.md](https://github.com/aws/aws-lambda-java-libs/blob/master/CONTRIBUTING.md) file.
126126

127127
We'd love to get your contributions to improve AWS Lambda OpenTracing Java SDK! Keep in mind when you submit your pull request, you'll need to sign the CLA via the click-through using CLA-Assistant. If you'd like to execute our corporate CLA, or if you have any questions, please drop us an email at open-source@newrelic.com.
128128

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
group = "com.newrelic.opentracing"
1+
group = com.newrelic.opentracing
22
version = 1.0-SNAPSHOT
33

44

0 commit comments

Comments
 (0)