small adjustments

Author: donchev7

cmd/cache-offloader.go

@@ -19,9 +19,9 @@ import (
 func getInMemoryStorage(cfg config.Config) http.Cacher {
 	switch strings.ToLower(cfg.CacheConfig.Strategy) {
 	case "lru":
-		return storage.NewLRUCache(cfg.CacheConfig.Size, 5*60 /*5 minutes*/)
+		return storage.NewLRUCache(cfg.CacheConfig.Size, cfg.CacheConfig.StaleInSeconds)
 	case "lfu":
-		storage.NewLFUCache(cfg.CacheConfig.Size, 5*60 /*5 minutes*/)
+		storage.NewLFUCache(cfg.CacheConfig.Size, cfg.CacheConfig.StaleInSeconds)
 	default:
 		log.Error().Msgf("Unknown cache strategy: %s", cfg.CacheConfig.Strategy)
 		log.Fatal().Msg("Supported cache strategies are LRU and LFU")

pkg/storage/helpers.go

@@ -13,10 +13,10 @@ func getSize(value model.Response) float64 {
 	return sizeMB
 }
 
-func getStaleStatus(timeStamp int64, staleDuration int64) uint8 {
-	if (time.Now().Unix() - timeStamp) >= staleDuration {
+func getStaleStatus(timeStamp int64, staleDuration int) uint8 {
+	if (time.Now().Unix() - timeStamp) >= int64(staleDuration) {
 		return model.StaleValue
-	} else {
-		return model.FreshValue
 	}
+
+	return model.FreshValue
 }

pkg/storage/memory-lfu.go

@@ -19,7 +19,7 @@ type LFUCache struct {
 	lookupTimeout time.Duration
 	lists         map[uint]*FrequencyList
 	cache         map[string]*list.Element
-	staleDuration int64
+	staleDuration int
 }
 
 type FrequencyList struct {
@@ -34,7 +34,7 @@ type LfuNode struct {
 	key       string
 }
 
-func NewLFUCache(maxSizeMB float64, staleInSeconds int64) *LFUCache {
+func NewLFUCache(maxSizeMB float64, staleInSeconds int) *LFUCache {
 	if maxSizeMB <= 0 {
 		maxSizeMB = 50.0
 	}
@@ -66,7 +66,10 @@ func (lfu *LFUCache) Store(ctx context.Context, key string, value *model.Respons
 
 	if found {
 		bodySizeMB -= getSize(*val.Value.(*LfuNode).value)
-		node := val.Value.(*LfuNode)
+		node, ok := val.Value.(*LfuNode)
+		if !ok {
+			log.Warn().Msg("The node is not a LfuNode")
+		}
 		node.value = value
 		node.timeStamp = time.Now().Unix()
 		lfu.update(val)
@@ -105,7 +108,10 @@ func (lfu *LFUCache) LookUp(ctx context.Context, key string) (*model.Response, e
 
 		if val, found := lfu.cache[key]; found {
 			lfu.update(val)
-			node := val.Value.(*LfuNode)
+			node, ok := val.Value.(*LfuNode)
+			if !ok {
+				log.Warn().Msg("The node is not a LfuNode")
+			}
 			response := node.value
 			response.StaleValue = getStaleStatus(node.timeStamp, lfu.staleDuration)
 

pkg/storage/memory-lru.go

@@ -17,7 +17,7 @@ type LRUCache struct {
 	capacityMB    float64
 	sizeMB        float64
 	lookupTimeout time.Duration
-	staleDuration int64
+	staleDuration int
 }
 
 type LRUNode struct {
@@ -26,7 +26,7 @@ type LRUNode struct {
 	timeStamp int64
 }
 
-func NewLRUCache(maxSizeMB float64, staleInSeconds int64) *LRUCache {
+func NewLRUCache(maxSizeMB float64, staleInSeconds int) *LRUCache {
 	if maxSizeMB <= 0 {
 		maxSizeMB = 50.0
 	}
@@ -55,7 +55,10 @@ func (lru *LRUCache) Store(ctx context.Context, key string, value *model.Respons
 
 	if val, found := lru.cache[key]; found {
 		bodySizeMB -= getSize(*val.Value.(*LRUNode).value)
-		node := val.Value.(*LRUNode)
+		node, ok := val.Value.(*LRUNode)
+		if !ok {
+			log.Warn().Msg("The node is not a LRUNode")
+		}
 		node.value = value
 		node.timeStamp = time.Now().Unix()
 
@@ -86,7 +89,10 @@ func (lru *LRUCache) LookUp(ctx context.Context, key string) (*model.Response, e
 
 		if value, found := lru.cache[key]; found {
 			lru.responses.MoveToFront(value)
-			node := value.Value.(*LRUNode)
+			node, ok := value.Value.(*LRUNode)
+			if !ok {
+				log.Warn().Msg("The node is not a LRUNode")
+			}
 			response := node.value
 			response.StaleValue = getStaleStatus(node.timeStamp, lru.staleDuration)