bug in new macro (typo?): alias is SAL (to SHL), not SAR

yjh-styx · hpax · commit 5a5057ad958b · 2025-10-08T11:49:54.000-07:00
diff --git a/x86/preinsns.pl b/x86/preinsns.pl
@@ -83,7 +83,7 @@
 		foreach my $ss (8, 16, 32, 64) {
 		    foreach my $opp (['SHL','66'], ['SAL','66'], ['SAR','f3'], ['SHR','f2']) {
 			my($op,$pp) = @$opp;
-			my $ndss = ',ND' unless ($ss == $os && $op ne 'SAR');
+			my $ndss = ',ND' unless ($ss == $os && $op ne 'SAL');
 			push(@ol, "$op$x reg$os,rm${os}*,reg$ss [rmv: $vex.lz.$pp.0f38.$w f7 /r] BMI2,SM0-1,!FL,$fl,$ndss");
 		    }
 		}

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@`
`83`	`83`	`foreach my $ss (8, 16, 32, 64) {`
`84`	`84`	`foreach my $opp (['SHL','66'], ['SAL','66'], ['SAR','f3'], ['SHR','f2']) {`
`85`	`85`	`my($op,$pp) = @$opp;`
`86`		`- my $ndss = ',ND' unless ($ss == $os && $op ne 'SAR');`
	`86`	`+ my $ndss = ',ND' unless ($ss == $os && $op ne 'SAL');`
`87`	`87`	`push(@ol, "$op$x reg$os,rm${os}*,reg$ss [rmv: $vex.lz.$pp.0f38.$w f7 /r] BMI2,SM0-1,!FL,$fl,$ndss");`
`88`	`88`	`}`
`89`	`89`	`}`