Add more test cases

Author: nettofarah

lib/graphql/query_resolver.rb

@@ -29,7 +29,7 @@ def self.map_dependencies(class_name, ast_node)
             current_class_name = selection.name.singularize.classify.constantize
             dependencies[name] = map_dependencies(current_class_name, selection)
           rescue NameError
-            selection_name = class_name.reflections[selection.name.to_sym].options[:class_name]
+            selection_name = class_name.reflections.with_indifferent_access[selection.name].options[:class_name]
             current_class_name = selection_name.singularize.classify.constantize
             dependencies[selection.name.to_sym] = map_dependencies(current_class_name, selection)
 

spec/graphql/query_resolver_spec.rb

@@ -6,26 +6,99 @@
     TestData.create_netto
   end
 
-  it 'does something useful' do
+  it 'groups queries' do
     data = nil
 
     queries = track_queries do
       data = GQL.query(%{
         query {
           recipes {
-            #title
+            title
+            ingredients { name }
+          }
+        }
+      })
+    end
+
+    expect(queries.size).to eq(2)
+    expect(queries.first).to eq('SELECT "recipes".* FROM "recipes"')
+    expect(queries.last).to eq('SELECT "ingredients".* FROM "ingredients" WHERE "ingredients"."recipe_id" IN (1, 2, 3, 4)')
+  end
+
+  it 'works with multiple levels of nesting' do
+    data = nil
 
+    queries = track_queries do
+      data = GQL.query(%{
+        query {
+          recipes {
+            title
             ingredients {
+              name, quantity
+              vendor { name }
+            }
+          }
+        }
+      })
+    end
+
+    expect(queries.size).to eq(3)
+    expect(queries[0]).to eq('SELECT "recipes".* FROM "recipes"')
+    expect(queries[1]).to eq('SELECT "ingredients".* FROM "ingredients" WHERE "ingredients"."recipe_id" IN (1, 2, 3, 4)')
+    expect(queries[2]).to eq('SELECT "vendors".* FROM "vendors" WHERE "vendors"."id" IN (1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11)')
+  end
+
+  it 'issues one SELECT call per level' do
+    data = nil
+
+    queries = track_queries do
+      data = GQL.query(%{
+        query {
+          restaurant(id: 1) {
+            name
+            owner {
               name
-              #vendor { name }
+              recipes {
+                title
+                ingredients {
+                  name, quantity
+                  vendor {
+                    name
+                  }
+                }
+              }
             }
-         }
+          }
         }
       })
     end
 
-    puts queries
+    expected_queries = [
+      'SELECT  "restaurants".* FROM "restaurants" WHERE "restaurants"."id" = ? LIMIT ?',
+      'SELECT "chefs".* FROM "chefs" WHERE "chefs"."id" = 1',
+      'SELECT "recipes".* FROM "recipes" WHERE "recipes"."chef_id" = 1',
+      'SELECT "ingredients".* FROM "ingredients" WHERE "ingredients"."recipe_id" IN (1, 2, 3, 4)',
+      'SELECT "vendors".* FROM "vendors" WHERE "vendors"."id" IN (1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11)'
+    ]
+
+    expect(queries).to eq(expected_queries)
+  end
+
+  it 'works with alias reflections' do
+    # Owner is an instance of Chef
+    query = %{
+      query {
+        restaurant(id: 1) {
+          name
+          owner { name }
+        }
+      }
+    }
+
+    queries = track_queries do
+      GQL.query(query)
+    end
 
-    expect(true).to eq(true)
+    expect(queries.size).to eq(2)
   end
 end

spec/support/graphql_schema.rb

@@ -68,14 +68,7 @@
   field :id, types.ID
   field :name, types.String
   field :quantity, types.Int
-
-  field :vendor do
-    type VendorType
-
-    resolve -> (obj, args, ctx) {
-      obj.vendor
-    }
-  end
+  field :vendor, VendorType
 end
 
 QueryRoot = GraphQL::ObjectType.define do
@@ -98,7 +91,10 @@
 
     resolve -> (obj, args, ctx) {
       id = args['id']
-      Restaurant.find(id)
+      
+      GraphQL::QueryResolver::run(Restaurant, ctx, RestaurantType) do
+        Restaurant.find(id)
+      end
     }
   end
 end