various interface changes based on internal feedback

Author: ramonsnir

.vscode/settings.json

@@ -2,5 +2,6 @@
     "go.lintFlags": [
         "--fast"
     ],
-    "go.lintTool": "golangci-lint"
+    "go.lintTool": "golangci-lint",
+    "files.insertFinalNewline": true
 }

docs/resources/environment_variable.md

@@ -23,16 +23,16 @@ description: |-
 ### Optional
 
 - `scopes` (Set of String)
-- `secret_value` (Attributes Set) (see [below for nested schema](#nestedatt--secret_value))
+- `secret_values` (Attributes Set) (see [below for nested schema](#nestedatt--secret_values))
 - `site_id` (String)
-- `value` (Attributes Set) (see [below for nested schema](#nestedatt--value))
+- `values` (Attributes Set) (see [below for nested schema](#nestedatt--values))
 
 ### Read-Only
 
 - `last_updated` (String)
 
-<a id="nestedatt--secret_value"></a>
-### Nested Schema for `secret_value`
+<a id="nestedatt--secret_values"></a>
+### Nested Schema for `secret_values`
 
 Required:
 
@@ -44,8 +44,8 @@ Optional:
 - `context_parameter` (String)
 
 
-<a id="nestedatt--value"></a>
-### Nested Schema for `value`
+<a id="nestedatt--values"></a>
+### Nested Schema for `values`
 
 Required:
 

docs/resources/site_build_settings.md

@@ -18,14 +18,19 @@ description: |-
 ### Required
 
 - `build_command` (String)
+- `production_branch` (String)
 - `publish_directory` (String)
 - `site_id` (String)
 
 ### Optional
 
 - `base_directory` (String)
+- `branch_deploy_all_branches` (Boolean)
+- `branch_deploy_branches` (List of String)
 - `build_image` (String)
+- `deploy_previews` (Boolean)
 - `functions_directory` (String)
+- `functions_region` (String)
 - `package_directory` (String)
 - `pretty_urls` (Boolean)
 - `stop_builds` (Boolean)

docs/resources/site_collaboration_settings.md

@@ -0,0 +1,27 @@
+---
+# generated by https://github.com/hashicorp/terraform-plugin-docs
+page_title: "netlify_site_collaboration_settings Resource - netlify"
+subcategory: ""
+description: |-
+  
+---
+
+# netlify_site_collaboration_settings (Resource)
+
+
+
+
+
+<!-- schema generated by tfplugindocs -->
+## Schema
+
+### Required
+
+- `netlify_drawer_in_branch_deploys` (Boolean)
+- `netlify_drawer_in_deploy_previews` (Boolean)
+- `netlify_heads_up_display` (Boolean)
+- `site_id` (String)
+
+### Read-Only
+
+- `last_updated` (String)

docs/resources/site_deploy_settings.md

@@ -0,0 +1,31 @@
+---
+# generated by https://github.com/hashicorp/terraform-plugin-docs
+page_title: "netlify_site_domain_settings Resource - netlify"
+subcategory: ""
+description: |-
+  
+---
+
+# netlify_site_domain_settings (Resource)
+
+
+
+
+
+<!-- schema generated by tfplugindocs -->
+## Schema
+
+### Required
+
+- `site_id` (String)
+
+### Optional
+
+- `branch_deploy_custom_domain` (String)
+- `custom_domain` (String)
+- `deploy_preview_custom_domain` (String)
+- `domain_aliases` (List of String)
+
+### Read-Only
+
+- `last_updated` (String)

docs/resources/site_domain_settings.md

@@ -52,6 +52,7 @@ resource "netlify_dns_record" "fish" {
   priority = 10
 }
 
+# TODO: verify this returns all DNS records
 data "netlify_dns_zone" "example" {
   name = "example-tf-test-test.com"
   depends_on = [

examples/dns/main.tf

@@ -23,7 +23,7 @@ resource "netlify_environment_variable" "woof" {
   account_id = data.netlify_account.current.id
   site_id    = data.netlify_site.platform_test.id
   key        = "WOOF"
-  value = [
+  values = [
     {
       value   = "dogs are here",
       context = "all",
@@ -35,7 +35,7 @@ resource "netlify_environment_variable" "meow" {
   account_id = data.netlify_account.current.id
   site_id    = data.netlify_site.platform_test.id
   key        = "TEST_MEOW"
-  value = [
+  values = [
     {
       value   = "roflmaocopter",
       context = "all",
@@ -47,7 +47,7 @@ resource "netlify_environment_variable" "secret_meow" {
   account_id = data.netlify_account.current.id
   site_id    = data.netlify_site.platform_test.id
   key        = "SECRET_TEST_MEOW"
-  secret_value = [
+  secret_values = [
     {
       value   = "secret roflmaocopter",
       context = "production",
@@ -62,7 +62,7 @@ resource "netlify_environment_variable" "secret_meow" {
 resource "netlify_environment_variable" "global_meow" {
   account_id = data.netlify_account.current.id
   key        = "TEST_MEOW"
-  value = [
+  values = [
     {
       value   = "global roflmaocopter",
       context = "all",

examples/env_vars/main.tf

@@ -8,9 +8,7 @@ terraform {
 }
 
 # `token` comes from NETLIFY_API_TOKEN, but can be specified with a Terraform variable
-provider "netlify" {
-  token = "nfp_C92ECMDqhbZpjtbhGmzGT2GQnFJSA4zvcc22"
-}
+provider "netlify" {}
 
 data "netlify_site" "test4" {
   account_slug = "netlify-testing"

examples/firewall_traffic_rules/main.tf

@@ -19,6 +19,7 @@ data "netlify_site" "platform_test" {
   name         = "platform-test-1"
 }
 
+# TODO: verify this returns all sites
 data "netlify_sites" "all" {
   account_slug = "netlify-testing"
 }