test: remove or simplify unreliable CDN caching e2e tests (#563)

* test: remove on-demand revalidation e2e tests

These are absolutely not worth their maintenance cost.

I've had enough.

* test: skip test for broken behaviour

* test: simplify cached response e2e tests

These are unreliable as written, and simply not worth their maintenance
cost.

Author: serhalp

tests/e2e/fixtures/edge-site/app/routes/stale-while-revalidate.tsx renamed to tests/e2e/fixtures/edge-site/app/routes/cacheable.tsx

@@ -8,9 +8,7 @@ export const loader = () => {
     },
     {
       headers: {
-        "CDN-Cache-Control":
-          "public, max-age=60, stale-while-revalidate=31536000",
-        "Cache-Tag": "stale-while-revalidate-tag",
+        "CDN-Cache-Control": "public, max-age=60",
       },
     },
   );
@@ -24,7 +22,7 @@ export default function SWRDemo() {
   const { message } = useLoaderData<typeof loader>();
   return (
     <div style={{ fontFamily: "system-ui, sans-serif", lineHeight: "1.4" }}>
-      <h1>Stale-while-revalidate</h1>
+      <h1>Cacheable</h1>
       <p>{message}</p>
     </div>
   );

tests/e2e/fixtures/edge-site/app/routes/cached-for-a-year.tsx

@@ -4,10 +4,9 @@ export default [
   index('routes/home.tsx'),
   route('about', 'routes/about.tsx'),
   route('blobs', 'routes/blobs.tsx'),
-  route('cached-for-a-year', 'routes/cached-for-a-year.tsx'),
+  route('cacheable', 'routes/cacheable.tsx'),
   route('context', 'routes/context.tsx'),
   route('headers', 'routes/headers.tsx'),
   route('images', 'routes/images.tsx'),
   route('middleware-header', 'routes/middleware-header.tsx'),
-  route('stale-while-revalidate', 'routes/stale-while-revalidate.tsx'),
 ] satisfies RouteConfig

tests/e2e/fixtures/edge-site/netlify/functions/purge-cdn.ts

@@ -7,8 +7,7 @@ export const loader = () => {
     },
     {
       headers: {
-        'CDN-Cache-Control': 'public, max-age=60, stale-while-revalidate=31536000, durable',
-        'Cache-Tag': 'stale-while-revalidate-tag',
+        'CDN-Cache-Control': 'public, max-age=60, durable',
       },
     },
   )
@@ -22,7 +21,7 @@ export default function SWRDemo() {
   const { message } = useLoaderData<typeof loader>()
   return (
     <div style={{ fontFamily: 'system-ui, sans-serif', lineHeight: '1.4' }}>
-      <h1>Stale-while-revalidate</h1>
+      <h1>Cacheable</h1>
       <p>{message}</p>
     </div>
   )

tests/e2e/fixtures/react-router-serverless-site/app/routes.ts

@@ -8,9 +8,7 @@ export const loader = () => {
     },
     {
       headers: {
-        "CDN-Cache-Control":
-          "public, max-age=60, stale-while-revalidate=31536000, durable",
-        "Cache-Tag": "stale-while-revalidate-tag",
+        "CDN-Cache-Control": "public, max-age=60, durable",
       },
     },
   );
@@ -24,7 +22,7 @@ export default function SWRDemo() {
   const { message } = useLoaderData<typeof loader>();
   return (
     <div style={{ fontFamily: "system-ui, sans-serif", lineHeight: "1.4" }}>
-      <h1>Stale-while-revalidate</h1>
+      <h1>Cacheable</h1>
       <p>{message}</p>
     </div>
   );