From 9f6c8c46b674f463c8afaab2d245ab44714a329b Mon Sep 17 00:00:00 2001
From: Mateusz Bocian <mrstork@users.noreply.github.com>
Date: Fri, 24 Oct 2025 10:37:16 -0400
Subject: [PATCH] fix: set span error states when blob operations fail

---
 packages/blobs/src/store.ts  | 11 +++++++++++
 packages/blobs/tsconfig.json |  4 ++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/packages/blobs/src/store.ts b/packages/blobs/src/store.ts
index 170ce1f0..503a379c 100644
--- a/packages/blobs/src/store.ts
+++ b/packages/blobs/src/store.ts
@@ -1,4 +1,5 @@
 import { getTracer, withActiveSpan } from '@netlify/otel'
+import { SpanStatusCode } from '@netlify/otel/opentelemetry'
 import { ListResponse, ListResponseBlob } from './backend/list.ts'
 import { Client, type Conditions } from './client.ts'
 import type { ConsistencyMode } from './consistency.ts'
@@ -179,10 +180,12 @@ export class Store {
       })
 
       if (res.status === 404) {
+        span?.setStatus({ code: SpanStatusCode.ERROR })
         return null
       }
 
       if (res.status !== 200) {
+        span?.setStatus({ code: SpanStatusCode.ERROR })
         throw new BlobsInternalError(res)
       }
 
@@ -207,6 +210,7 @@ export class Store {
         return res.body
       }
 
+      span?.setStatus({ code: SpanStatusCode.ERROR })
       throw new BlobsInternalError(res)
     })
   }
@@ -225,10 +229,12 @@ export class Store {
       })
 
       if (res.status === 404) {
+        span?.setStatus({ code: SpanStatusCode.ERROR })
         return null
       }
 
       if (res.status !== 200 && res.status !== 304) {
+        span?.setStatus({ code: SpanStatusCode.ERROR })
         throw new BlobsInternalError(res)
       }
 
@@ -310,10 +316,12 @@ export class Store {
       })
 
       if (res.status === 404) {
+        span?.setStatus({ code: SpanStatusCode.ERROR })
         return null
       }
 
       if (res.status !== 200 && res.status !== 304) {
+        span?.setStatus({ code: SpanStatusCode.ERROR })
         throw new BlobsInternalError(res)
       }
 
@@ -422,6 +430,7 @@ export class Store {
         }
       }
 
+      span?.setStatus({ code: SpanStatusCode.ERROR })
       throw new BlobsInternalError(res)
     })
   }
@@ -469,6 +478,7 @@ export class Store {
         }
       }
 
+      span?.setStatus({ code: SpanStatusCode.ERROR })
       throw new BlobsInternalError(res)
     })
   }
@@ -603,6 +613,7 @@ export class Store {
               let directories: string[] = []
 
               if (![200, 204, 404].includes(res.status)) {
+                span?.setStatus({ code: SpanStatusCode.ERROR })
                 throw new BlobsInternalError(res)
               }
 
diff --git a/packages/blobs/tsconfig.json b/packages/blobs/tsconfig.json
index 7fedf6ee..83e9a4b7 100644
--- a/packages/blobs/tsconfig.json
+++ b/packages/blobs/tsconfig.json
@@ -3,7 +3,7 @@
     "allowImportingTsExtensions": true,
     "emitDeclarationOnly": true,
     "target": "ES2020",
-    "module": "es2020",
+    "module": "nodenext",
     "allowJs": true,
     "declaration": true,
     "declarationMap": false,
@@ -11,7 +11,7 @@
     "outDir": "./dist",
     "removeComments": false,
     "strict": true,
-    "moduleResolution": "node",
+    "moduleResolution": "nodenext",
     "esModuleInterop": true,
     "skipLibCheck": true,
     "forceConsistentCasingInFileNames": true