Skip to content

Commit 9fe3782

Browse files
cheemrstork
andauthored
feat: add instrumentation to @netlify/blobs (#384)
* depend on @netlify/otel in blobs * add instrumentation to @netlify/blobs * move otel package up a notch in the ws config, because blobs needs it now * manually toposort the node 18 test build * manually toposort the release please --------- Co-authored-by: Mateusz Bocian <mrstork@users.noreply.github.com>
1 parent cd26425 commit 9fe3782

File tree

6 files changed

+307
-206
lines changed

6 files changed

+307
-206
lines changed

.github/workflows/release-please.yaml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,15 @@ jobs:
8989
fi
9090
env:
9191
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
92+
- if: ${{ steps.release.outputs['packages/otel--release_created'] || github.event_name == 'workflow_dispatch' }}
93+
run: |
94+
if [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then
95+
npm publish packages/otel/ --provenance --access=public || true
96+
else
97+
npm publish packages/otel/ --provenance --access=public
98+
fi
99+
env:
100+
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
92101
- if: ${{ steps.release.outputs['packages/blobs--release_created'] || github.event_name == 'workflow_dispatch' }}
93102
run: |
94103
if [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then
@@ -242,15 +251,6 @@ jobs:
242251
fi
243252
env:
244253
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
245-
- if: ${{ steps.release.outputs['packages/otel--release_created'] || github.event_name == 'workflow_dispatch' }}
246-
run: |
247-
if [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then
248-
npm publish packages/otel/ --provenance --access=public || true
249-
else
250-
npm publish packages/otel/ --provenance --access=public
251-
fi
252-
env:
253-
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
254254
- if: ${{ steps.release.outputs['packages/ai--release_created'] || github.event_name == 'workflow_dispatch' }}
255255
run: |
256256
if [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then

.github/workflows/test.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,9 @@ jobs:
8888
- name: Build
8989
# NOTE: These are run in the specified order, so they must be in topological order
9090
run: >-
91-
npm run build -w ./packages/types -w ./packages/dev-utils -w ./packages/runtime-utils -w ./packages/blobs -w
92-
./packages/edge-functions -w ./packages/functions
91+
npm run build -w ./packages/types -w ./packages/dev-utils -w ./packages/runtime-utils -w ./packages/otel -w
92+
./packages/blobs -w ./packages/edge-functions -w ./packages/functions
9393
- name: Tests
9494
run: >-
95-
npm run test -w ./packages/types -w ./packages/dev-utils -w ./packages/runtime-utils -w ./packages/blobs -w
96-
./packages/edge-functions -w ./packages/functions
95+
npm run test -w ./packages/types -w ./packages/dev-utils -w ./packages/runtime-utils -w ./packages/otel -w
96+
./packages/blobs -w ./packages/edge-functions -w ./packages/functions

package-lock.json

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"packages/types",
77
"packages/dev-utils",
88
"packages/runtime-utils",
9+
"packages/otel",
910
"packages/blobs",
1011
"packages/cache",
1112
"packages/edge-functions/prod",
@@ -21,8 +22,7 @@
2122
"packages/ai",
2223
"packages/nuxt-module",
2324
"packages/vite-plugin",
24-
"packages/vite-plugin-tanstack-start",
25-
"packages/otel"
25+
"packages/vite-plugin-tanstack-start"
2626
],
2727
"version": "0.0.0",
2828
"scripts": {

packages/blobs/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@
7777
},
7878
"dependencies": {
7979
"@netlify/dev-utils": "4.3.0",
80+
"@netlify/otel": "^4.3.0",
8081
"@netlify/runtime-utils": "2.2.0"
8182
}
8283
}

0 commit comments

Comments
 (0)