fix: actually handle AWS SDK errors as intended (#7184)

* fix: actually handle AWS SDK error as intended

* refactor: rename misleading `detectAwsSdkError`

* fix: handle non-normalized function invocation errors

Author: serhalp

src/lib/functions/synchronous.ts

@@ -8,7 +8,7 @@ import type { LambdaEvent } from 'lambda-local'
 import { chalk, logPadded, NETLIFYDEVERR } from '../../utils/command-helpers.js'
 import renderErrorTemplate from '../render-error-template.js'
 
-import { detectAwsSdkError } from './utils.js'
+import { warnIfAwsSdkError } from './utils.js'
 import type { InvocationError } from './netlify-function.js'
 
 // Annoyingly, `isReadableStream` refines to the `Readable` interface rather than the
@@ -152,8 +152,7 @@ const handleErr = async (
   request: express.Request,
   response: express.Response,
 ) => {
-  // @ts-expect-error -- XXX(serhalp): Expects `error` but passes `err`, so it has never worked. Fixed in stacked PR.
-  detectAwsSdkError({ err })
+  warnIfAwsSdkError({ error: err })
 
   const acceptsHtml = request.headers.accept?.includes('text/html') ?? false
   const errorString = typeof err === 'string' ? err : formatLambdaLocalError(err, acceptsHtml)

src/lib/functions/utils.ts

@@ -3,8 +3,7 @@ import { MISSING_AWS_SDK_WARNING } from '../log.js'
 
 import type { InvocationError } from './netlify-function.js'
 
-// TODO(serhalp): Rename? This doesn't "detect", it maybe logs a warning.
-export const detectAwsSdkError = ({ error }: { error: Error | InvocationError | string }): void => {
+export const warnIfAwsSdkError = ({ error }: { error: Error | InvocationError | string }): void => {
   const isAwsSdkError =
     typeof error === 'object' &&
     'errorMessage' in error &&
@@ -16,10 +15,10 @@ export const detectAwsSdkError = ({ error }: { error: Error | InvocationError |
   }
 }
 
-// XXX(serhalp): This appears to be a bug? In the background and scheduled function code paths this can receive plain
-// errors, but this is assuming normalized `InvocationError`s only.
 export const formatLambdaError = (err: Error | InvocationError): string =>
-  chalk.red(`${'errorType' in err ? err.errorType : ''}: ${'errorMessage' in err ? err.errorMessage : ''}`)
+  chalk.red(
+    `${'errorType' in err ? err.errorType : 'Error'}: ${'errorMessage' in err ? err.errorMessage : err.message}`,
+  )
 
 // should be equivalent to https://github.com/netlify/proxy/blob/main/pkg/functions/request.go#L105
 const exceptionsList = new Set([