refactor: remove extraneous assertions from copyTemplateDir

This removes the `assert` calls we were making in `copyTemplateDir`, as
well as the tests that exercise this behavior. These asserts probably
made more sense in a pre-TypeScript world, but we no longer need them as
TypeScript serves the same purpose.

Author: ndhoule

src/utils/copy-template-dir/copy-template-dir.ts

@@ -18,7 +18,6 @@
 // COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-import assert from 'assert'
 import fs from 'fs'
 import path from 'path'
 import { pipeline } from 'stream'
@@ -53,10 +52,6 @@ async function writeFile(outDir: string, vars: Record<string, string>, file: Ent
 
 // High throughput template dir writes
 export async function copyTemplateDir(srcDir: string, outDir: string, vars: Record<string, string>): Promise<string[]> {
-  assert.strictEqual(typeof srcDir, 'string')
-  assert.strictEqual(typeof outDir, 'string')
-  assert.strictEqual(typeof vars, 'object')
-
   await fs.promises.mkdir(outDir, { recursive: true })
 
   const rs: ReaddirpStream = readdirp(srcDir)

tests/unit/utils/copy-template-dir/copy-template-dir.test.ts

@@ -11,14 +11,6 @@ const __filename = fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
 
 describe('copyTemplateDir', () => {
-  test('should assert input values', async () => {
-    // @ts-expect-error TS(2554) FIXME: Expected 3 arguments, but got 0.
-    await expect(copyTemplateDir()).rejects.toThrow(/string/)
-    // @ts-expect-error TS(2554) FIXME: Expected 3 arguments, but got 1.
-    await expect(copyTemplateDir('foo')).rejects.toThrow(/string/)
-    await expect(copyTemplateDir('foo', 'bar', 'err')).rejects.toThrow(/object/)
-  })
-
   test('should write a bunch of files', async () => {
     const checkCreatedFileNames = (names: string[]) => {
       expect(names).toContain('.a')