Skip to content

Commit 1cecd04

Browse files
committed
v4.4.2
1 parent fb88bff commit 1cecd04

File tree

4 files changed

+40
-19
lines changed

4 files changed

+40
-19
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@netdata/netdata-ui",
3-
"version": "4.4.1",
3+
"version": "4.4.2",
44
"description": "netdata UI kit",
55
"main": "dist/index.js",
66
"module": "dist/es6/index.js",

src/components/table/body/header/cell.js

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,15 @@ const rerenderSelector = state => ({
3939
selecting: state.selectedRows,
4040
})
4141

42-
const BodyHeaderCell = ({ header, table, testPrefix, coloredSortedColumn, index }) => {
42+
const BodyHeaderCell = ({
43+
header,
44+
table,
45+
testPrefix,
46+
coloredSortedColumn,
47+
index,
48+
children,
49+
isSubheader,
50+
}) => {
4351
useTableState(rerenderSelector)
4452

4553
const { column } = header
@@ -75,7 +83,7 @@ const BodyHeaderCell = ({ header, table, testPrefix, coloredSortedColumn, index
7583
background: "columnHighlight",
7684
backgroundOpacity: "0.2",
7785
})}
78-
padding={[1, 2]}
86+
padding={isSubheader ? [0] : [1, 2]}
7987
{...headStyles}
8088
column
8189
>
@@ -90,7 +98,12 @@ const BodyHeaderCell = ({ header, table, testPrefix, coloredSortedColumn, index
9098
>
9199
<Sorting sortable={column.getCanSort()} sorting={column.getIsSorted()} />
92100
{column.isPlaceholder ? null : (
93-
<Label sorting={column.getIsSorted()} sortable={column.getCanSort()}>
101+
<Label
102+
as={column.columnDef.labelAs}
103+
{...column.columnDef.labelProps}
104+
sorting={column.getIsSorted()}
105+
sortable={column.getCanSort()}
106+
>
94107
{flexRender(column.columnDef.header, header.getContext())}
95108
</Label>
96109
)}
@@ -99,6 +112,7 @@ const BodyHeaderCell = ({ header, table, testPrefix, coloredSortedColumn, index
99112
</Flex>
100113
<Info meta={meta} />
101114
<ResizeHandler header={header} table={table} />
115+
{children}
102116
</Flex>
103117
)
104118
}

src/components/table/body/header/index.js

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,25 @@ const rerenderSelector = state => {
1414
}
1515
}
1616

17-
const HeaderGroup = ({ headerGroup, testPrefix, ...rest }) => (
18-
<Flex
19-
id={headerGroup.id}
20-
data-testid={`netdata-table-headRow${testPrefix}`}
21-
flex
22-
background="tableRowBg2"
23-
>
24-
{headerGroup.headers.map((header, index) => (
25-
<Cell key={header.id} index={index} {...rest} header={header} testPrefix={testPrefix} />
26-
))}
27-
</Flex>
28-
)
17+
const HeaderGroup = ({ id, headers, testPrefix, ...rest }) => {
18+
return (
19+
<Flex id={id} data-testid={`netdata-table-headRow${testPrefix}`} flex background="tableRowBg2">
20+
{headers.map((header, index) => (
21+
<Cell key={header.id} index={index} {...rest} header={header} testPrefix={testPrefix}>
22+
{!!header.subHeaders.length && (
23+
<HeaderGroup
24+
headers={header.subHeaders}
25+
id={header.id}
26+
key={header.id}
27+
{...rest}
28+
isSubheader
29+
/>
30+
)}
31+
</Cell>
32+
))}
33+
</Flex>
34+
)
35+
}
2936

3037
const HeaderGroups = ({ groups, size, side, ...rest }) => {
3138
if (!groups[0].headers.length) return null
@@ -44,9 +51,7 @@ const HeaderGroups = ({ groups, size, side, ...rest }) => {
4451
flex="grow"
4552
column
4653
>
47-
{groups.map(headerGroup => (
48-
<HeaderGroup headerGroup={headerGroup} key={headerGroup.id} {...rest} />
49-
))}
54+
<HeaderGroup headers={groups[0].headers} id={groups[0].id} key={groups[0].id} {...rest} />
5055
</Flex>
5156
)
5257
}

src/components/table/table.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ const Table = memo(
9797
virtualizeOptions,
9898
tableRef,
9999
className,
100+
width,
100101
...rest
101102
},
102103
ref
@@ -219,6 +220,7 @@ const Table = memo(
219220
flex="1"
220221
ref={ref}
221222
className={className}
223+
width={width}
222224
>
223225
<Header
224226
q={globalFilter}

0 commit comments

Comments
 (0)