Skip to content

Commit 16d5d8a

Browse files
committed
Fixed toggle actions.
1 parent c2f6865 commit 16d5d8a

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

src/components/drops/menu/index.js

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,17 @@ const Menu = forwardRef(
5252
[onChange]
5353
)
5454

55-
const onClickOutside = useCallback(event => {
56-
if (
57-
ref.current !== event.target &&
58-
!getAncestors(event.target).some(node => node === ref.current)
59-
) {
60-
close()
61-
}
62-
}, [])
55+
const onClickOutside = useCallback(
56+
event => {
57+
if (
58+
ref.current !== event.target &&
59+
!getAncestors(event.target).some(node => node === ref.current)
60+
) {
61+
close()
62+
}
63+
},
64+
[close]
65+
)
6366

6467
const clonedChildren = useClonedChildren(children, setRef, {
6568
onClick: toggleIsOpen,

src/hooks/use-toggle/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,17 @@ export default (initialValue = false, { on, off, toggle: onToggle } = {}) => {
2020

2121
return nextValue
2222
})
23-
}, [])
23+
}, [on, off, onToggle])
2424

2525
const toggleOn = useCallback(() => {
2626
setToggle(true)
2727
if (on) on()
28-
}, [])
28+
}, [on])
2929

3030
const toggleOff = useCallback(() => {
3131
setToggle(false)
3232
if (off) off()
33-
}, [])
33+
}, [off])
3434

3535
return [value, toggle, toggleOn, toggleOff]
3636
}

0 commit comments

Comments
 (0)