Skip to content

Commit 0eff85a

Browse files
authored
fix: helm chart - update ssl-redirect annotations to string format in values.yaml (#328)
2 parents 9ef1eae + f7e3ca1 commit 0eff85a

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

charts/diode/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -325,14 +325,14 @@ helm show values diode/diode
325325
| hydra.job.extraInitContainers | string | `"{{ include \"diode.hydra.extrainitcontainers\" . }}"` | extra init containers |
326326
| hydra.secret.enabled | bool | `false` | secret enabled |
327327
| hydra.secret.nameOverride | string | `"diode-hydra-secret"` | existing secret name |
328-
| ingressNginx | object | `{"annotations":{},"controller":{"allowSnippetAnnotations":true},"enabled":true,"extraHttpPaths":{},"grpcAnnotations":{"nginx.ingress.kubernetes.io/proxy-body-size":"25m","nginx.ingress.kubernetes.io/ssl-redirect":true},"hostname":"","httpAnnotations":{"nginx.ingress.kubernetes.io/ssl-redirect":true},"ingressClass":"nginx","pathPrefix":"/diode","tls":{}}` | ref: https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/values.yaml |
328+
| ingressNginx | object | `{"annotations":{},"controller":{"allowSnippetAnnotations":true},"enabled":true,"extraHttpPaths":{},"grpcAnnotations":{"nginx.ingress.kubernetes.io/proxy-body-size":"25m","nginx.ingress.kubernetes.io/ssl-redirect":"true"},"hostname":"","httpAnnotations":{"nginx.ingress.kubernetes.io/ssl-redirect":"true"},"ingressClass":"nginx","pathPrefix":"/diode","tls":{}}` | ref: https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/values.yaml |
329329
| ingressNginx.controller | object | `{"allowSnippetAnnotations":true}` | ingress annotations |
330330
| ingressNginx.controller.allowSnippetAnnotations | bool | `true` | allow snippet annotations |
331331
| ingressNginx.enabled | bool | `true` | ingress-nginx enabled |
332332
| ingressNginx.extraHttpPaths | object | `{}` | ingress extra http paths |
333-
| ingressNginx.grpcAnnotations | object | `{"nginx.ingress.kubernetes.io/proxy-body-size":"25m","nginx.ingress.kubernetes.io/ssl-redirect":true}` | ingress grpc annotations |
333+
| ingressNginx.grpcAnnotations | object | `{"nginx.ingress.kubernetes.io/proxy-body-size":"25m","nginx.ingress.kubernetes.io/ssl-redirect":"true"}` | ingress grpc annotations |
334334
| ingressNginx.hostname | string | `""` | hostname |
335-
| ingressNginx.httpAnnotations | object | `{"nginx.ingress.kubernetes.io/ssl-redirect":true}` | ingress http annotations |
335+
| ingressNginx.httpAnnotations | object | `{"nginx.ingress.kubernetes.io/ssl-redirect":"true"}` | ingress http annotations |
336336
| ingressNginx.ingressClass | string | `"nginx"` | ingress class |
337337
| ingressNginx.pathPrefix | string | `"/diode"` | ingress path prefix |
338338
| ingressNginx.tls | object | `{}` | ingress tls |
@@ -373,4 +373,4 @@ Unless required by applicable law or agreed to in writing, software
373373
distributed under the License is distributed on an "AS IS" BASIS,
374374
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
375375
See the License for the specific language governing permissions and
376-
limitations under the License.
376+
limitations under the License.

charts/diode/README.md.gotmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,4 +217,4 @@ Unless required by applicable law or agreed to in writing, software
217217
distributed under the License is distributed on an "AS IS" BASIS,
218218
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
219219
See the License for the specific language governing permissions and
220-
limitations under the License.
220+
limitations under the License.

charts/diode/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,10 +380,10 @@ ingressNginx:
380380
# - diode.example.com
381381
# -- ingress http annotations
382382
httpAnnotations:
383-
nginx.ingress.kubernetes.io/ssl-redirect: true
383+
nginx.ingress.kubernetes.io/ssl-redirect: "true"
384384
# -- ingress grpc annotations
385385
grpcAnnotations:
386-
nginx.ingress.kubernetes.io/ssl-redirect: true
386+
nginx.ingress.kubernetes.io/ssl-redirect: "true"
387387
nginx.ingress.kubernetes.io/proxy-body-size: "25m"
388388
# -- ingress path prefix
389389
pathPrefix: /diode

0 commit comments

Comments
 (0)