Skip to content

20465 fix script re-upload #20765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+10 −1
Closed

20465 fix script re-upload #20765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdf4fe4
20465 fix script re-upload
arthanson Nov 7, 2025
6367530
20465 fix script re-upload
arthanson Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion netbox/extras/forms/scripts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,17 @@ def save(self, *args, **kwargs):
storage = storages.create_storage(storages.backends["scripts"])

filename = self.cleaned_data['upload_file'].name
self.instance.file_path = filename
data = self.cleaned_data['upload_file']

# If editing an existing file, delete the old one first to avoid random suffix
if self.instance.pk and self.instance.file_path:
try:
storage.delete(self.instance.file_path)
except FileNotFoundError:
pass

# Save the new file and capture the actual filename
self.instance.file_path = filename
storage.save(filename, data)

# need to skip ManagedFileForm save method
Expand Down