feat(tests): Update ACL rule tests for generic fields

Replaces `source_prefix` and `destination_prefix` with generic `source`
and `destination` fields in ACL rule tests. Updates test cases to
include `source_type`, `source_id`, `destination_type`, and
`destination_id` for better alignment with the updated generic model.

Author: pheus

netbox_acls/tests/api/test_access_list_rules.py

@@ -3,8 +3,13 @@
 from utilities.testing import APIViewTestCases
 from virtualization.models import Cluster, ClusterType, VirtualMachine
 
-from netbox_acls.choices import *
-from netbox_acls.models import *
+from netbox_acls.choices import (
+    ACLActionChoices,
+    ACLProtocolChoices,
+    ACLRuleActionChoices,
+    ACLTypeChoices,
+)
+from netbox_acls.models import AccessList, ACLExtendedRule, ACLStandardRule
 
 
 class ACLStandardRuleAPIViewTestCase(APIViewTestCases.APIViewTestCase):
@@ -98,7 +103,7 @@ def setUpTestData(cls):
                 index=10,
                 description="Rule 10",
                 action=ACLRuleActionChoices.ACTION_PERMIT,
-                source_prefix=prefix1,
+                source=prefix1,
             ),
             ACLStandardRule(
                 access_list=access_list_device,
@@ -112,7 +117,7 @@ def setUpTestData(cls):
                 index=10,
                 description="Rule 10",
                 action=ACLRuleActionChoices.ACTION_DENY,
-                source_prefix=prefix2,
+                source=prefix2,
             ),
         )
         ACLStandardRule.objects.bulk_create(acl_standard_rules)
@@ -123,14 +128,16 @@ def setUpTestData(cls):
                 "index": 30,
                 "description": "Rule 30",
                 "action": ACLRuleActionChoices.ACTION_DENY,
-                "source_prefix": prefix2.id,
+                "source_type": "ipam.prefix",
+                "source_id": prefix2.id,
             },
             {
                 "access_list": access_list_vm.id,
                 "index": 20,
                 "description": "Rule 30",
                 "action": ACLRuleActionChoices.ACTION_PERMIT,
-                "source_prefix": prefix1.id,
+                "source_type": "ipam.prefix",
+                "source_id": prefix1.id,
             },
             {
                 "access_list": access_list_vm.id,
@@ -237,9 +244,9 @@ def setUpTestData(cls):
                 description="Rule 10",
                 action=ACLRuleActionChoices.ACTION_PERMIT,
                 protocol=ACLProtocolChoices.PROTOCOL_TCP,
-                source_prefix=prefix1,
+                source=prefix1,
                 source_ports=[22, 443],
-                destination_prefix=prefix1,
+                destination=prefix1,
                 destination_ports=[22, 443],
             ),
             ACLExtendedRule(
@@ -254,8 +261,8 @@ def setUpTestData(cls):
                 index=10,
                 description="Rule 10",
                 action=ACLRuleActionChoices.ACTION_DENY,
-                source_prefix=prefix2,
-                destination_prefix=prefix1,
+                source=prefix2,
+                destination=prefix1,
             ),
         )
         ACLExtendedRule.objects.bulk_create(acl_extended_rules)
@@ -267,9 +274,11 @@ def setUpTestData(cls):
                 "description": "Rule 30",
                 "action": ACLRuleActionChoices.ACTION_DENY,
                 "protocol": ACLProtocolChoices.PROTOCOL_UDP,
-                "source_prefix": prefix2.id,
+                "source_type": "ipam.prefix",
+                "source_id": prefix2.id,
                 "source_ports": [53],
-                "destination_prefix": prefix2.id,
+                "destination_type": "ipam.prefix",
+                "destination_id": prefix2.id,
                 "destination_ports": [53],
             },
             {
@@ -278,8 +287,10 @@ def setUpTestData(cls):
                 "description": "Rule 30",
                 "action": ACLRuleActionChoices.ACTION_PERMIT,
                 "protocol": ACLProtocolChoices.PROTOCOL_ICMP,
-                "source_prefix": prefix1.id,
-                "destination_prefix": prefix2.id,
+                "source_type": "ipam.prefix",
+                "source_id": prefix1.id,
+                "destination_type": "ipam.prefix",
+                "destination_id": prefix2.id,
             },
             {
                 "access_list": access_list_vm.id,

netbox_acls/tests/api/test_access_lists.py

@@ -4,8 +4,12 @@
 from utilities.testing import APIViewTestCases
 from virtualization.models import Cluster, ClusterType, VirtualMachine, VMInterface
 
-from netbox_acls.choices import *
-from netbox_acls.models import *
+from netbox_acls.choices import (
+    ACLActionChoices,
+    ACLAssignmentDirectionChoices,
+    ACLTypeChoices,
+)
+from netbox_acls.models import AccessList, ACLInterfaceAssignment
 
 
 class AccessListAPIViewTestCase(APIViewTestCases.APIViewTestCase):