feat(form): ACLExtendedRule: Change validation to support multiple destinations; Add validation to restrict to a single Destination

Author: rvveber

netbox_acls/forms/models.py

@@ -56,9 +56,13 @@
 
 # Sets a standard error message for ACL rules with an action of remark, but no source is set.
 error_message_action_remark_source_set = "Action is set to remark, Source CANNOT be set."
+# Sets a standard error message for ACL rules with an action of remark, but no destination is set.
+error_message_action_remark_destination_set = "Action is set to remark, Destination CANNOT be set."
 
 # Sets a standard error message for ACL rules when more than one IP/Host sources are set.
 error_message_sources_more_than_one = "Only one IP/Host related Source can be specified."
+# Sets a standard error message for ACL rules when more than one IP/Host destinations are set.
+error_message_destinations_more_than_one = "Only one IP/Host related Destination can be specified."
 
 class AccessListForm(NetBoxModelForm):
     """
@@ -736,9 +740,11 @@ def clean(self):
         Validates form inputs before submitting:
         - Check if action set to remark, but no remark set.
         - Check if action set to remark, but source set.
+        - Check if action set to remark, but destination set.
         - Check if action set to remark, but protocol set
         - Check remark set, but action not set to remark.
         - Check not more than one source is set.
+        - Check not more than one destination is set.
         """
         super().clean()
         cleaned_data = self.cleaned_data
@@ -748,8 +754,9 @@ def clean(self):
         remark = cleaned_data.get("remark")
 
         sources = ["source_prefix", "source_iprange", "source_ipaddress", "source_aggregate", "source_service"]
+        destinations = ["destination_prefix", "destination_iprange", "destination_ipaddress", "destination_aggregate", "destination_service"]
+        
         source_ports = cleaned_data.get("source_ports")
-        destination_prefix = cleaned_data.get("destination_prefix")
         destination_ports = cleaned_data.get("destination_ports")
         protocol = cleaned_data.get("protocol")
 
@@ -760,11 +767,13 @@ def clean(self):
             # Check if action set to remark, but source set.
             for source in sources:
                 error_message[source] = [error_message_action_remark_source_set]
+                
+            # Check if action set to remark, but destination set.
+            for destination in destinations:
+                error_message[destination] = [error_message_action_remark_destination_set]
 
             if source_ports:
                 error_message["source_ports"] = ["Action is set to remark, Source Ports CANNOT be set."]
-            if destination_prefix:
-                error_message["destination_prefix"] = ["Action is set to remark, Destination Prefix CANNOT be set."]
             if destination_ports:
                 error_message["destination_ports"] = ["Action is set to remark, Destination Ports CANNOT be set."]
             if protocol:
@@ -777,5 +786,10 @@ def clean(self):
             for source in sources:
                 error_message[source] = [error_message_sources_more_than_one]
 
+        # Check not more than one destination is set.
+        elif sum(bool(cleaned_data.get(destination)) for destination in destinations) > 1:
+            for destination in destinations:
+                error_message[destination] = [error_message_destinations_more_than_one]
+
         if error_message:
             raise ValidationError(error_message)