Clarify circular dependency usage with Scope.REQUEST

bilby91 · web-flow · commit ac4c78808d95 · 2022-02-12T17:14:39.000-03:00
After spending a couple of hours debugging an issue with circular dependencies and Scope.REQUEST, I had some conversations over Discord and it was agreed that adding the following clarification will be helpful.
diff --git a/content/fundamentals/circular-dependency.md b/content/fundamentals/circular-dependency.md
@@ -54,7 +54,7 @@ export class CommonService {
 }
 ```
 
-> warning **Warning** The order of instantiation is indeterminate. Make sure your code does not depend on which constructor is called first.
+> warning **Warning** The order of instantiation is indeterminate. Make sure your code does not depend on which constructor is called first. Having circular dependencies depend on providers with Scope.REQUEST can lead to undefined dependencies. More information available [here](https://github.com/nestjs/nest/issues/5778) 
 
 #### ModuleRef class alternative
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ export class CommonService {`
`54`	`54`	`}`
`55`	`55`	```
`56`	`56`
`57`		`-> warning Warning The order of instantiation is indeterminate. Make sure your code does not depend on which constructor is called first.`
	`57`	`+> warning Warning The order of instantiation is indeterminate. Make sure your code does not depend on which constructor is called first. Having circular dependencies depend on providers with Scope.REQUEST can lead to undefined dependencies. More information available [here](https://github.com/nestjs/nest/issues/5778)`
`58`	`58`
`59`	`59`	`#### ModuleRef class alternative`
`60`	`60`