Skip to content

Commit 4589f9b

Browse files
committed
"Fixes nv-file-select reset bug when queued" #584
Merge branch 'master' of https://github.com/denkan/angular-file-upload into denkan-master # Conflicts: # dist/angular-file-upload.js # dist/angular-file-upload.js.map # dist/angular-file-upload.min.js # dist/angular-file-upload.min.js.map # src/services/FileSelect.js
2 parents 4f50057 + ecc2f59 commit 4589f9b

File tree

7 files changed

+16
-13
lines changed

7 files changed

+16
-13
lines changed

dist/angular-file-upload.js

Lines changed: 6 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angular-file-upload.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angular-file-upload.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angular-file-upload.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-file-upload",
3-
"version": "2.3.3",
3+
"version": "2.3.4",
44
"homepage": "https://github.com/nervgh/angular-file-upload",
55
"description": "Angular File Upload is a module for the AngularJS framework",
66
"author": {

src/directives/FileSelect.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ export default function __identity($parse, FileUploader, FileSelect) {
1717

1818
var object = new FileSelect({
1919
uploader: uploader,
20-
element: element
20+
element: element,
21+
scope: scope
2122
});
2223

2324
object.getOptions = $parse(attributes.options).bind(object, scope);

src/services/FileSelect.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ let {
99
} = angular;
1010

1111

12-
export default function __identity(FileDirective) {
12+
export default function __identity($compile, FileDirective) {
1313

1414

1515
return class FileSelect extends FileDirective {
@@ -67,13 +67,14 @@ export default function __identity(FileDirective) {
6767
this.uploader.addToQueue(files, options, filters);
6868
if(this.isEmptyAfterSelection()) {
6969
this.element.prop('value', null);
70-
this.element.replaceWith(this.element = this.element.clone(true)); // IE fix
70+
this.element.replaceWith($compile(this.element.clone())(this.scope)); // IE fix
7171
}
7272
}
7373
}
7474
}
7575

7676

7777
__identity.$inject = [
78+
'$compile',
7879
'FileDirective'
7980
];

0 commit comments

Comments
 (0)