Merge #447 drop "eslint-plugin-prettier", invoke prettier explicitly

Author: justinmk

.eslintrc.js

@@ -1,12 +1,26 @@
+/**
+ * @type {import('eslint').Linter.LegacyConfig}
+ */
 module.exports = {
   extends: ['airbnb-base', 'plugin:@typescript-eslint/recommended', 'prettier'],
-  plugins: ['unicorn', 'import', 'prettier', '@typescript-eslint'],
+  plugins: ['unicorn', 'import', '@typescript-eslint'],
   parser: '@typescript-eslint/parser',
   parserOptions: {
     project: './tsconfig.json',
     ecmaVersion: 'latest',
     sourceType: 'module',
   },
+  reportUnusedDisableDirectives: true,
+  ignorePatterns: [
+    '.eslintrc.js',
+    'packages/*/lib/',
+    'packages/*/bin/',
+    'packages/neovim/scripts/',
+    'packages/integration-tests/__tests__/',
+    'examples/rplugin/node/',
+    'packages/example-plugin/',
+    'packages/example-plugin-decorators/',
+  ],
   env: {
     node: true,
     es2024: true,
@@ -66,9 +80,6 @@ module.exports = {
     'no-shadow': 'off',
     'prefer-destructuring': 'off', // Intentionally disabled trash.
 
-    // prettier things
-    'prettier/prettier': 'error',
-
     'import/extensions': 'off',
     'import/prefer-default-export': 'off',
 

.prettierignore

@@ -0,0 +1,2 @@
+# some tests seem to create these files in CI
+nvim-win64

package-lock.json

@@ -18,7 +18,6 @@
     "eslint-config-airbnb-base": "^15.0.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-prettier": "^5.1.3",
     "eslint-plugin-unicorn": "^50.0.1",
     "husky": "^9.1.4",
     "lint-staged": "^15.2.10",
@@ -34,7 +33,8 @@
     "test-staged": "npm run test-staged --workspaces --if-present -- --",
     "test-missing-apis": "npm run test-missing-apis --workspaces --if-present",
     "test-lint": "npm run lint",
-    "lint": "eslint --format=unix packages/*/src/**/*.ts packages/*/src/*.ts"
+    "lint": "prettier --check . && eslint --format=unix .",
+    "fixlint": "prettier --write . && eslint --fix --format=unix ."
   },
   "husky": {
     "hooks": {
@@ -43,7 +43,7 @@
   },
   "lint-staged": {
     "*.{ts,js}": [
-      "eslint --fix",
+      "npm run fixlint",
       "npm run test-staged"
     ]
   },

package.json

@@ -96,15 +96,13 @@ function wrapper(cls: PluginWrapperConstructor, options?: PluginOptions): any {
 }
 
 // Can decorate a class with options object
-// eslint-disable-next-line import/export
+
 export function Plugin(
   outter: any
 ): (cls: PluginWrapperConstructor, options?: PluginOptions) => any;
 
-// eslint-disable-next-line import/export
 export function Plugin(outter: any): any;
 
-// eslint-disable-next-line import/export
 export function Plugin(outter: any): any {
   /**
    * Decorator should support

packages/decorators/src/plugin/plugin.ts

@@ -9,23 +9,23 @@ import { ApiInfo } from '../types/ApiInfo';
 export interface UiAttachOptions {
   rgb?: boolean;
   override?: boolean;
-  // eslint-disable-next-line camelcase
+
   ext_cmdline?: boolean;
-  // eslint-disable-next-line camelcase
+
   ext_hlstate?: boolean;
-  // eslint-disable-next-line camelcase
+
   ext_linegrid?: boolean;
-  // eslint-disable-next-line camelcase
+
   ext_messages?: boolean;
-  // eslint-disable-next-line camelcase
+
   ext_multigrid?: boolean;
-  // eslint-disable-next-line camelcase
+
   ext_popupmenu?: boolean;
-  // eslint-disable-next-line camelcase
+
   ext_tabline?: boolean;
-  // eslint-disable-next-line camelcase
+
   ext_wildmenu?: boolean;
-  // eslint-disable-next-line camelcase
+
   ext_termcolors?: boolean;
 }
 
@@ -56,7 +56,7 @@ export interface Command {
   nargs: string;
   range: string;
   name: string;
-  // eslint-disable-next-line camelcase
+
   script_id: number;
   bar: boolean;
   register: boolean;
@@ -65,7 +65,7 @@ export interface Command {
   complete?: null;
   addr?: any;
   count?: any;
-  // eslint-disable-next-line camelcase
+
   complete_arg?: any;
 }
 

packages/neovim/src/api/Neovim.ts

@@ -81,7 +81,6 @@ export function createChainableApi(
     },
 
     set: (target: any, prop: string, value: any, receiver: Promise<any>) => {
-      // eslint-disable-next-line no-param-reassign
       if (receiver && (receiver instanceof Promise || 'then' in receiver)) {
         receiver.then(obj => {
           if (prop in obj) {

packages/neovim/src/api/utils/createChainableApi.ts

@@ -9,7 +9,7 @@ export interface NvimPluginOptions {
 
 export interface AutocmdOptions {
   pattern?: string;
-  // eslint-disable-next-line no-eval
+
   eval?: string;
   sync?: boolean;
 }
@@ -24,7 +24,7 @@ export interface CommandOptions {
 export interface NvimFunctionOptions {
   sync?: boolean;
   range?: string;
-  // eslint-disable-next-line no-eval
+
   eval?: string;
 }
 

packages/neovim/src/host/NvimPlugin.ts

@@ -2,7 +2,7 @@ import { NVIM_SYNC, NVIM_SPEC, NVIM_METHOD_NAME } from './properties';
 
 export interface AutocmdOptions {
   pattern: string;
-  // eslint-disable-next-line no-eval
+
   eval?: string;
   sync?: boolean;
 }