feat: native support for intervals <-> Neo4j duration #796
+180
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nord-erik
commented
Oct 28, 2025
| class SparkToNeo4jDataConverter extends DataConverter[Value] { | ||
|
|
||
| override def convert(value: Any, dataType: DataType): Value = { | ||
| dataType match { |
Contributor
Author
There was a problem hiding this comment.
looking into how to re-write this to still match on value (and incorporate below)
Contributor
Author
There was a problem hiding this comment.
... but I don't think it's important...
nord-erik
commented
Oct 28, 2025
nord-erik
commented
Oct 28, 2025
spark-3/src/test/scala/org/neo4j/spark/DataSourceWriterTSE.scala
Outdated
Show resolved
Hide resolved
nord-erik
force-pushed
the
en/feat-native-types
branch
5 times, most recently
from
b8a5787 to
078fcf0
Compare
fbiville
reviewed
Nov 7, 2025
spark-3/src/test/scala/org/neo4j/spark/DataSourceWriterTSE.scala
Outdated
Show resolved
Hide resolved
spark-3/src/test/scala/org/neo4j/spark/DataSourceWriterTSE.scala
Outdated
Show resolved
Hide resolved
spark-3/src/test/scala/org/neo4j/spark/DataSourceWriterTSE.scala
Outdated
Show resolved
Hide resolved
nord-erik
force-pushed
the
en/feat-native-types
branch
3 times, most recently
from
ca3a137 to
175e0dd
Compare
fbiville
approved these changes
Nov 23, 2025
nord-erik
force-pushed
the
en/feat-native-types
branch
2 times, most recently
from
45ca291 to
6961941
Compare
Contributor
Author
|
When this is released, document in: neo4j/docs-spark#83 |
nord-erik
force-pushed
the
en/feat-native-types
branch
from
6961941 to
13fb6da
Compare
this commit introduces a new way to write from Spark SQL interval types to Neo4j duration type. commit is additive, i.e. the previous method to write Neo4j duration type via custom struct is still possible, and should therefore be backwards compatible. Fixes CONN-341
nord-erik
force-pushed
the
en/feat-native-types
branch
from
13fb6da to
69647b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit introduces a new way to write from Spark SQL interval types to Neo4j duration type.
commit is additive, i.e. the previous method to write Neo4j duration type via custom struct is
still possible, and should therefore be backwards compatible.
part of CONN-341