Test in use count

Author: technige

neo4j/bolt/connection.py

@@ -419,18 +419,15 @@ def release(self, connection):
             connection.in_use = False
 
     def in_use_connection_count(self, address):
+        """ Count the number of connections currently in use to a given
+        address.
+        """
         try:
             connections = self.connections[address]
         except KeyError:
             return 0
         else:
-            in_use_count = 0
-
-            for connection in list(connections):
-                if connection.in_use:
-                    in_use_count += 1
-
-            return in_use_count
+            return sum(1 if connection.in_use else 0 for connection in connections)
 
     def remove(self, address):
         """ Remove an address from the connection pool, if present, closing

test/integration/test_connection.py

@@ -108,3 +108,11 @@ def test_cannot_acquire_after_close(self):
             pool.close()
             with self.assertRaises(ServiceUnavailable):
                 _ = pool.acquire_direct("X")
+
+    def test_in_use_count(self):
+        address = ("127.0.0.1", 7687)
+        self.assertEqual(self.pool.in_use_connection_count(address), 0)
+        connection = self.pool.acquire_direct(address)
+        self.assertEqual(self.pool.in_use_connection_count(address), 1)
+        self.pool.release(connection)
+        self.assertEqual(self.pool.in_use_connection_count(address), 0)