Fixed bug where broken transaction kills session

Author: technige

neo4j/v1/api.py

@@ -433,7 +433,7 @@ def _run_transaction(self, access_mode, unit_of_work, *args, **kwargs):
             except (ServiceUnavailable, SessionExpired) as error:
                 last_error = error
             except TransientError as error:
-                if is_retriable_transientError(error):
+                if is_retriable_transient_error(error):
                     last_error = error
                 else:
                     raise error
@@ -465,7 +465,7 @@ def __bookmark__(self, result):
         pass
 
 
-def is_retriable_transientError(error):
+def is_retriable_transient_error(error):
     """
     :type error: TransientError
     """
@@ -572,7 +572,6 @@ def close(self):
         """ Close this transaction, triggering either a COMMIT or a ROLLBACK.
         """
         if not self.closed():
-            self.sync()
             try:
                 self.sync()
             except CypherError:

test/integration/test_session.py

@@ -24,7 +24,7 @@
 from neo4j.v1 import \
     READ_ACCESS, WRITE_ACCESS, \
     CypherError, SessionError, TransactionError, \
-    Node, Relationship, Path
+    Node, Relationship, Path, CypherSyntaxError
 
 from test.integration.tools import DirectIntegrationTestCase
 
@@ -339,6 +339,14 @@ def test_can_rollback_transaction_using_with_block(self):
                                  "RETURN a.foo", {"n": node_id})
             assert len(list(result)) == 0
 
+    def test_broken_transaction_should_not_break_session(self):
+        with self.driver.session() as session:
+            with self.assertRaises(CypherSyntaxError):
+                with session.begin_transaction() as tx:
+                    tx.run("X")
+            with session.begin_transaction() as tx:
+                tx.run("RETURN 1")
+
 
 class BookmarkingTestCase(DirectIntegrationTestCase):