Skip to content

Commit 1cb7c2c

Browse files
committed
updated stepfiles to work with new result cursor
1 parent 4d5cc90 commit 1cb7c2c

File tree

4 files changed

+37
-27
lines changed

4 files changed

+37
-27
lines changed

test/tck/steps/bolt_compability_steps.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,14 @@ def step_impl(context, size, type):
8080

8181
@when("the driver asks the server to echo this (?P<unused>.+) back")
8282
def step_impl(context, unused):
83-
context.results = {"as_string": send_string("RETURN " + as_cypher_text(context.expected)),
84-
"as_parameters": send_parameters("RETURN {input}", {'input': context.expected})}
83+
context.results = [ send_string("RETURN " + as_cypher_text(context.expected)).stream(), send_parameters("RETURN {input}", {'input': context.expected}).stream()]
8584

8685

8786
@step("the value given in the result should be the same as what was sent")
8887
def step_impl(context):
8988
assert len(context.results) > 0
90-
for result in context.results.values():
91-
result_value = result[0].values()[0]
89+
for result in context.results:
90+
result_value = result.next().values()[0]
9291
assert result_value == context.expected
9392

9493

test/tck/steps/cypher_compability_steps.py

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -31,28 +31,30 @@ def step_impl(context, statement):
3131
send_string(statement)
3232

3333

34-
@when("running: (?P<statement>.+)")
34+
@step("running: (?P<statement>.+)")
3535
def step_impl(context, statement):
36-
context.results = {"as_string": send_string(statement)}
36+
context.rcs = [send_string(statement)]
37+
context.results = [x.stream() for x in context.rcs]
3738

3839

39-
@then("result")
40-
def step_impl(context):
41-
result = context.results["as_string"]
42-
given = driver_result_to_comparable_result(result)
43-
expected = table_to_comparable_result(context.table)
44-
if not unordered_equal(given, expected):
45-
raise Exception("Does not match given: \n%s expected: \n%s" % (given, expected))
46-
47-
48-
@when('running parametrized: (?P<statement>.+)')
40+
@step('running parametrized: (?P<statement>.+)')
4941
def step_impl(context, statement):
5042
assert len(context.table.rows) == 1
5143
keys = context.table.headings
5244
values = context.table.rows[0]
5345
parameters = {keys[i]: parse_values(values[i]) for i in range(len(keys))}
5446

55-
context.results = {"as_string": send_parameters(statement, parameters)}
47+
context.rcs = [send_parameters(statement, parameters)]
48+
context.results = [x.stream() for x in context.rcs]
49+
50+
51+
@then("result")
52+
def step_impl(context):
53+
expected = table_to_comparable_result(context.table)
54+
for result in context.results:
55+
given = driver_result_to_comparable_result(result)
56+
if not unordered_equal(given, expected):
57+
raise Exception("Does not match given: \n%s expected: \n%s" % (given, expected))
5658

5759

5860
def _driver_value_to_comparable(val):

test/tck/steps/driver_result_api_steps.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,14 +120,26 @@ def step_impl(context, plan_type):
120120
assert getattr(plan, row[0].replace(" ", "_")) is not None
121121

122122

123-
@step("the summaries collection of `notifications` is empty")
123+
@step("the summaries `notifications` is empty list")
124124
def step_impl(context):
125125
for summary in context.summaries:
126126
assert len(summary.notifications) == 0
127127

128128

129-
@step("the summaries collection of `notifications` is not empty")
129+
@step("the summaries `notifications` has one notification with")
130130
def step_impl(context):
131+
131132
for summary in context.summaries:
132-
print(summary.notifications)
133-
assert len(summary.notifications) != 0
133+
assert len(summary.notifications) == 1
134+
notification = summary.notifications[0]
135+
for row in context.table:
136+
if row[0] == 'position':
137+
position = getattr(notification, row[0].replace(" ","_"))
138+
expected_position = parse_values(row[1])
139+
for position_key, value in expected_position.items():
140+
assert value == getattr(position, position_key.replace(" ", "_"))
141+
else:
142+
assert getattr(notification, row[0].replace(" ","_")) == parse_values(row[1])
143+
144+
145+

test/tck/tck_util.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,17 @@
2323
from neo4j.v1 import GraphDatabase
2424

2525
driver = GraphDatabase.driver("bolt://localhost")
26+
session = driver.session()
2627

2728

2829
def send_string(text):
29-
session = driver.session()
3030
cursor = session.run(text)
31-
session.close()
32-
return list(cursor.stream())
31+
return cursor
3332

3433

3534
def send_parameters(statement, parameters):
36-
session = driver.session()
3735
cursor = session.run(statement, parameters)
38-
session.close()
39-
return list(cursor.stream())
36+
return cursor
4037

4138

4239
def to_unicode(val):

0 commit comments

Comments
 (0)