removed deprecated lastBookmark() (#1316)

Author: MaxAake

packages/core/src/session.ts

@@ -362,18 +362,6 @@ class Session {
     this._hasTx = false
   }
 
-  /**
-   * Return the bookmarks received following the last completed {@link Transaction}.
-   *
-   * @deprecated This method will be removed in version 6.0. Please, use {@link Session#lastBookmarks} instead.
-   *
-   * @return {string[]} A reference to a previous transaction.
-   * @see {@link Session#lastBookmarks}
-   */
-  lastBookmark (): string[] {
-    return this.lastBookmarks()
-  }
-
   /**
    * Return the bookmarks received following the last completed {@link Transaction}.
    *

packages/core/test/session.test.ts

@@ -268,19 +268,7 @@ describe('session', () => {
       })
   })
 
-  describe('.lastBookmark()', () => {
-    it.each([
-      [bookmarks.Bookmarks.empty()],
-      [new bookmarks.Bookmarks('bookmark1')],
-      [new bookmarks.Bookmarks(['bookmark1', 'bookmark2'])]
-    ])('should return the bookmark informed in the object creation', (bookmarks) => {
-      const session = newSessionWithConnection(newFakeConnection(), false, 1000, bookmarks)
-
-      expect(session.lastBookmark()).toEqual(bookmarks.values())
-    })
-  })
-
-  describe('.lastBookmark()', () => {
+  describe('.lastBookmarks()', () => {
     it.each([
       [bookmarks.Bookmarks.empty()],
       [new bookmarks.Bookmarks('bookmark1')],

packages/neo4j-driver-deno/lib/core/session.ts

@@ -139,23 +139,6 @@ export default class RxSession {
     return this.close()
   }
 
-  /**
-   * Returns the bookmarks received following the last successfully completed query, which is executed
-   * either in an {@link RxTransaction} obtained from this session instance or directly through one of
-   * the {@link RxSession#run} method of this session instance.
-   *
-   * If no bookmarks were received or if this transaction was rolled back, the bookmarks value will not be
-   * changed.
-   *
-   * @deprecated This method will be removed in 6.0 version. Please, use {@link RxSession#lastBookmarks} instead.
-   *
-   * @public
-   * @returns {string[]}
-   */
-  lastBookmark () {
-    return this.lastBookmarks()
-  }
-
   /**
    * Returns the bookmarks received following the last successfully completed query, which is executed
    * either in an {@link RxTransaction} obtained from this session instance or directly through one of

packages/neo4j-driver/src/session-rx.js

@@ -414,19 +414,6 @@ describe('#integration rx-session', () => {
 })
 
 describe('#unit rx-session', () => {
-  describe('lastBookmark', () => {
-    ;[
-      bookmarks.Bookmarks.empty(),
-      new bookmarks.Bookmarks('bookmark1'),
-      new bookmarks.Bookmarks(['bookmark1', 'bookmark2'])
-    ].forEach(bookmarks => {
-      it(`should return ${bookmarks}`, () => {
-        const session = newSession(bookmarks)
-        expect(session.lastBookmark()).toBe(bookmarks.values())
-      })
-    })
-  })
-
   describe('lastBookmarks', () => {
     ;[
       bookmarks.Bookmarks.empty(),

packages/neo4j-driver/test/rx/session.test.js

@@ -81,7 +81,6 @@ const txConfig7: TransactionConfig = {
 
 const tx1: Observable<RxTransaction> = rxSession.beginTransaction()
 const bookmarks: string[] = rxSession.lastBookmarks()
-const bookmark: string[] = rxSession.lastBookmark()
 
 const observable1: Observable<number> = rxSession.executeRead(
   (tx: RxTransaction) => {