fix: supportsMultiDb and supportsTransactionConfig where not trying resolved adresses

This methods were only trying to connect to the seed server address to check the protocol version.

Author: bigmontz

bolt-connection/src/connection-provider/connection-provider-routing.js

@@ -174,12 +174,11 @@ export default class RoutingConnectionProvider extends PooledConnectionProvider
     for (let i = 0; i < addresses.length; i++) {
       try {
         const connection = await createChannelConnection(
-          this._address,
+          addresses[i],
           this._config,
           this._createConnectionErrorHandler(),
           this._log
         )
-
         const protocolVersion = connection.protocol()
           ? connection.protocol().version
           : null
@@ -194,8 +193,6 @@ export default class RoutingConnectionProvider extends PooledConnectionProvider
       } catch (error) {
         lastError = error
       }
-
-      return false
     }
 
     if (lastError) {

bolt-connection/src/connection/connection-channel.js

@@ -188,7 +188,7 @@ export default class ChannelConnection extends Connection {
           if (metadata) {
             // read server version from the response metadata, if it is available
             const serverVersion = metadata.server
-            if (!this.version) {
+            if (!this.version || serverVersion) {
               this.version = serverVersion
             }
 

test/internal/node/routing.driver.boltkit.test.js

@@ -617,7 +617,7 @@ describe('#stub-routing routing driver with stub server', () => {
 
   function getRoutingTable (driver, database) {
     const connectionProvider = driver._getOrCreateConnectionProvider()
-    return connectionProvider._routingTables[database || '']
+    return connectionProvider._routingTableRegistry.get(database || '', {})
   }
 
   function numberOfOpenConnections (driver) {

test/resources/boltstub/v3/acquire_endpoints.script

@@ -3,7 +3,7 @@
 !: AUTO RESET
 !: AUTO GOODBYE
 
-C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {}} {}
+C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {"address": "127.0.0.1:9001"}} {}
    PULL_ALL
 S: SUCCESS {"fields": ["ttl", "servers"]}
    RECORD [9223372036854775807, [{"addresses": ["127.0.0.1:9007","127.0.0.1:9008"],"role": "WRITE"}, {"addresses": ["127.0.0.1:9005","127.0.0.1:9006"], "role": "READ"},{"addresses": ["127.0.0.1:9001","127.0.0.1:9002","127.0.0.1:9003"], "role": "ROUTE"}]]

test/resources/boltstub/v3/acquire_endpoints_and_exit.script

@@ -2,7 +2,7 @@
 !: AUTO HELLO
 !: AUTO RESET
 
-C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {}} {}
+C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {"address": "127.0.0.1:9001"}} {}
    PULL_ALL
 S: SUCCESS {"fields": ["ttl", "servers"]}
    RECORD [9223372036854775807, [{"addresses": ["127.0.0.1:9007","127.0.0.1:9008"],"role": "WRITE"}, {"addresses": ["127.0.0.1:9005","127.0.0.1:9006"], "role": "READ"},{"addresses": ["127.0.0.1:9001","127.0.0.1:9002","127.0.0.1:9003"], "role": "ROUTE"}]]

test/resources/boltstub/v3/acquire_endpoints_dead.script

@@ -2,6 +2,6 @@
 !: AUTO HELLO
 !: AUTO RESET
 
-C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {}} {}
+C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {"address": "127.0.0.1:9001"}} {}
    PULL_ALL
 S: <EXIT>

test/resources/boltstub/v3/acquire_endpoints_multiple_records.script

@@ -3,7 +3,7 @@
 !: AUTO RESET
 !: AUTO GOODBYE
 
-C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {}} {}
+C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {"address": "127.0.0.1:9001"}} {}
    PULL_ALL
 S: SUCCESS {"fields": ["ttl", "servers"]}
    RECORD [9223372036854775807, [{"addresses": ["127.0.0.1:9001"],"role": "WRITE"}, {"addresses": ["127.0.0.1:9002","127.0.0.1:9003"], "role": "READ"},{"addresses": ["127.0.0.1:9001","127.0.0.1:9002"], "role": "ROUTE"}]]

test/resources/boltstub/v3/acquire_endpoints_no_readers.script

@@ -3,7 +3,7 @@
 !: AUTO RESET
 !: AUTO GOODBYE
 
-C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {}} {}
+C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {"address": "127.0.0.1:9001"}} {}
    PULL_ALL
 S: SUCCESS {"fields": ["ttl", "servers"]}
    RECORD [9223372036854775807, [{"addresses": ["127.0.0.1:9001"],"role": "WRITE"},{"addresses": ["127.0.0.1:9001","127.0.0.1:9002","127.0.0.1:9003"], "role": "ROUTE"}]]

test/resources/boltstub/v3/acquire_endpoints_no_records.script

@@ -3,7 +3,7 @@
 !: AUTO RESET
 !: AUTO GOODBYE
 
-C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {}} {}
+C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {"address": "127.0.0.1:9001"}} {}
    PULL_ALL
 S: SUCCESS {"fields": ["ttl", "servers"]}
    SUCCESS {}

test/resources/boltstub/v3/acquire_endpoints_no_routers.script

@@ -3,7 +3,7 @@
 !: AUTO RESET
 !: AUTO GOODBYE
 
-C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {}} {}
+C: RUN "CALL dbms.cluster.routing.getRoutingTable($context)" {"context": {"address": "127.0.0.1:9001"}} {}
    PULL_ALL
 S: SUCCESS {"fields": ["ttl", "servers"]}
    RECORD [9223372036854775807, [{"addresses": ["127.0.0.1:9001"],"role": "WRITE"},{"addresses": ["127.0.0.1:9001"], "role": "READ"}]]