Add tests for v1 package import

Author: jakewins

README.md

@@ -87,6 +87,11 @@ See files under `examples/` on how to use.
 This runs the test suite against a fresh download of Neo4j.
 Or `npm test` if you already have a running version of a compatible Neo4j server.
 
+For development, you can have the build tool rerun the tests each time you change 
+the source code:
+
+    gulp watch-n-test
+
 ### Testing on windows
 Running tests on windows requires PhantomJS installed and its bin folder added in windows system variable `Path`.  
 To run the same test suite, run `.\runTest.ps1` instead in powershell with admin right.  

gulpfile.js

@@ -156,9 +156,13 @@ gulp.task('run-browser-test', function(){
 });
 
 gulp.task('watch', function () {
-    watch('src/**/*.js', batch(function (events, done) {
-        gulp.start('all', done);
-    }));
+  return watch('src/**/*.js', batch(function (events, done) {
+      gulp.start('all', done);
+  }));
+});
+
+gulp.task('watch-n-test', ['test-nodejs'], function () {
+  return gulp.watch(['src/**/*.js', "test/**/*.js"], ['test-nodejs'] );
 });
 
 var neo4jLinuxUrl = 'http://alpha.neohq.net/dist/neo4j-enterprise-3.0.0-M01-NIGHTLY-unix.tar.gz';
@@ -198,6 +202,7 @@ var runPowershell = function( cmd ) {
     child.stdin.end(); //end input
 }
 
+/** Set the project version, controls package.json and version.js */
 gulp.task('set', function() {
   // Get the --version arg from command line
   var version = minimist(process.argv.slice(2), { string: 'version' }).version;

src/index.js

@@ -17,14 +17,7 @@
  * limitations under the License.
  */
 
-import {int, isInt} from './v1/integer';
-import Driver from './v1/driver';
-import VERSION from './version';
-import * as v1 from './v1/index.js';
-
-let USER_AGENT = "neo4j-javascript/" + VERSION;
-
-console.log(v1);
+import * as v1 from './v1/index';
 
 export default {
   v1: v1

src/version.js

@@ -17,4 +17,11 @@
  * limitations under the License.
  */
 
+// DO NOT CHANGE THE VERSION BELOW HERE
+// This is set by the build system at release time, using
+//   gulp set --version <releaseversion>
+//
+// This is set up this way to keep the version in the code in
+// sync with the npm package version, and to allow the build
+// system to control version names at packaging time.
 export default { VERSION : "0.0.0-dev" };

test/neo4j-driver.test.js

@@ -0,0 +1,42 @@
+/**
+ * Copyright (c) 2002-2015 "Neo Technology,"
+ * Network Engine for Objects in Lund AB [http://neotechnology.com]
+ *
+ * This file is part of Neo4j.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+describe('neo4j-driver', function() {
+  it('should expose version 1 of the API as a property', function(done) {
+    // When
+    var neo4jDriver = require("../lib");
+
+    // Then I can access and use V1 of the API
+    var driver = neo4jDriver.v1.driver("bolt://localhost");
+    driver.session().run( "RETURN 1" )
+      .then( function() { driver.close(); })
+      .then( done );
+  });
+
+  it('should expose version 1 of the API package', function(done) {
+    // When
+    var neo4jV1 = require("../lib/v1");
+    
+    // Then I can access and use V1 of the API
+    var driver = neo4jV1.driver("bolt://localhost");
+    driver.session().run( "RETURN 1" )
+      .then( function() { driver.close(); })
+      .then( done );
+  });
+});

test/v1/session.test.js

@@ -135,7 +135,7 @@ describe('session', function() {
     var params = {prop: "string"}
     // When & Then
     var result = driver.session().run( statement, params );
-    result.then(function( records ) {
+    result.then(function() {
       var sum = result.summarize();
       expect(sum.statement.text).toBe( statement );
       expect(sum.statement.parameters).toBe( params );
@@ -154,7 +154,7 @@ describe('session', function() {
     var params = {prop: "string"}
     // When & Then
     var result = driver.session().run( statement, params );
-    result.then(function( records ) {
+    result.then(function() {
       var sum = result.summarize();
       expect(sum.hasPlan()).toBe(true);
       expect(sum.hasProfile()).toBe(false);
@@ -174,7 +174,7 @@ describe('session', function() {
     var params = {prop: "string"}
     // When & Then
     var result = driver.session().run( statement, params );
-    result.then(function( records ) {
+    result.then(function() {
       var sum = result.summarize();
       expect(sum.hasPlan()).toBe(true); //When there's a profile, there's a plan
       expect(sum.hasProfile()).toBe(true);
@@ -195,7 +195,7 @@ describe('session', function() {
     var statement = "EXPLAIN MATCH (n), (m) RETURN n, m";
     // When & Then
     var result = driver.session().run( statement );
-    result.then(function( records ) {
+    result.then(function() {
       var sum = result.summarize();
       expect(sum.notifications.length).toBeGreaterThan(0);
       expect(sum.notifications[0].code).toBe("Neo.ClientNotification.Statement.CartesianProduct");