Correct exporting of vector features in ts files (#1356)

Primarily adds vector and Vector to the index.d.ts exports. Also ensures that VectorType is consistently exported only as a type (for type annotations)

Author: MaxAake

packages/neo4j-driver-deno/lib/mod.ts

@@ -270,7 +270,7 @@ function driver (
           routingContext: parsedUrl.query
         })
     } else {
-      if (!isEmptyObjectOrNull(parsedUrl.query)) {
+      if (isEmptyObjectOrNull(parsedUrl.query) !== true) {
         throw new Error(
           `Parameters are not supported with none routed scheme. Given URL: '${url}'`
         )
@@ -330,7 +330,8 @@ const types = {
   LocalDateTime,
   LocalTime,
   Time,
-  Integer
+  Integer,
+  Vector
 }
 
 /**
@@ -534,6 +535,7 @@ export {
   notificationFilterMinimumSeverityLevel,
   clientCertificateProviders,
   vector,
+  Vector,
   rule,
   RecordObjectMapping,
   StandardCase
@@ -568,7 +570,6 @@ export type {
   ClientCertificateProvider,
   ClientCertificateProviders,
   RotatingClientCertificateProvider,
-  Vector,
   VectorType,
   Rule,
   Rules,

packages/neo4j-driver-lite/src/index.ts

@@ -83,7 +83,6 @@ import {
   resolveCertificateProvider,
   isVector,
   Vector,
-  VectorType,
   vector,
   Rule,
   Rules,
@@ -297,7 +296,6 @@ const types = {
   Time,
   Integer,
   Vector,
-  VectorType,
   Rule,
   Rules,
   ProtocolVersion
@@ -425,6 +423,7 @@ const forExport = {
   clientCertificateProviders,
   isVector,
   vector,
+  Vector,
   rule,
   mappingDecorators,
   RecordObjectMapping,
@@ -507,7 +506,6 @@ export {
   isVector,
   vector,
   Vector,
-  VectorType,
   Rule,
   Rules,
   rule,

packages/neo4j-driver/src/index.js

@@ -27,6 +27,7 @@ import driver, {
   RxResult,
   Session,
   Record,
+  VectorType,
   types
 } from '../../'
 
@@ -82,6 +83,7 @@ const dummy: any = null
 const rxSession: RxSession = dummy
 const rxTransaction: RxTransaction = dummy
 const rxResult: RxResult = dummy
+const vectorType: VectorType = dummy
 
 const record: Record = new Record(['role'], [124])
 
@@ -104,6 +106,7 @@ const instanceOfRxSession: boolean = dummy instanceof types.RxSession
 const instanceOfRxTransaction: boolean = dummy instanceof types.RxTransaction
 const instanceOfRxManagedTransaction: boolean = dummy instanceof types.RxManagedTransaction
 const instanceOfRxResult: boolean = dummy instanceof types.RxResult
+const instanceOfVector: boolean = dummy instanceof types.Vector
 
 const instanceOfDriverDriver: boolean = dummy instanceof driver.Driver
 const instanceOfDriverNeo4jError: boolean = dummy instanceof driver.Neo4jError

packages/neo4j-driver/test/types/export.test.ts

@@ -47,7 +47,8 @@ import {
   notificationFilterDisabledCategory,
   NotificationFilterDisabledClassification,
   notificationFilterDisabledClassification,
-  authTokenManagers
+  authTokenManagers,
+  vector
 } from '../../types/index'
 
 import Driver from '../../types/driver'
@@ -137,6 +138,8 @@ const neo4jIsPathSegment: boolean = isPathSegment({})
 const neo4jIsRelationship: boolean = isRelationship({})
 const neo4jIsUnboundRelationship: boolean = isUnboundRelationship({})
 
+const vectorConstructorFunction = vector(Int16Array.from([0]))
+
 const unknownSeverityString: string = notificationSeverityLevel.UNKNOWN
 const warningSeverityString: string = notificationSeverityLevel.WARNING
 const informationSeverityString: string = notificationSeverityLevel.INFORMATION

packages/neo4j-driver/test/types/index.test.ts

@@ -106,7 +106,10 @@ import {
   StandardCase,
   MappedQueryResult,
   types as coreTypes,
-  isVector
+  isVector,
+  vector,
+  Vector,
+  VectorType
 } from 'neo4j-driver-core'
 import {
   AuthToken,
@@ -185,6 +188,7 @@ declare const types: {
   RxTransaction: typeof RxTransaction
   RxManagedTransaction: typeof RxManagedTransaction
   RxResult: typeof RxResult
+  Vector: typeof Vector
 }
 
 declare const session: {
@@ -309,6 +313,8 @@ declare const forExport: {
   logging: typeof logging
   clientCertificateProviders: typeof clientCertificateProviders
   isVector: typeof isVector
+  vector: typeof vector
+  Vector: typeof Vector
 }
 
 export {
@@ -391,7 +397,9 @@ export {
   notificationFilterMinimumSeverityLevel,
   logging,
   clientCertificateProviders,
-  isVector
+  isVector,
+  vector,
+  Vector
 }
 
 export type {
@@ -421,7 +429,8 @@ export type {
   rule,
   RecordObjectMapping,
   StandardCase,
-  MappedQueryResult
+  MappedQueryResult,
+  VectorType
 }
 
 export default forExport