Fixed unit test in RoundRobinAddressSetTest

Author: lutovich

driver/src/main/java/org/neo4j/driver/internal/cluster/ClusterRoutingTable.java

@@ -78,16 +78,17 @@ private Set<BoltServerAddress> servers()
     public synchronized RoutingTableChange update( ClusterComposition cluster )
     {
         expirationTimeout = cluster.expirationTimestamp();
-        Set<BoltServerAddress> pre = servers();
+        Set<BoltServerAddress> previousServers = servers();
+
         readers.update( cluster.readers() );
         writers.update( cluster.writers() );
         routers.update( cluster.routers() );
-        Set<BoltServerAddress> cur = servers();
+        Set<BoltServerAddress> currentServers = servers();
 
-        Set<BoltServerAddress> added = new HashSet<>( cur );
-        Set<BoltServerAddress> removed = new HashSet<>( pre );
-        added.removeAll( pre );
-        removed.removeAll( cur );
+        Set<BoltServerAddress> added = new HashSet<>( currentServers );
+        Set<BoltServerAddress> removed = new HashSet<>( previousServers );
+        added.removeAll( previousServers );
+        removed.removeAll( currentServers );
         return new RoutingTableChange( added, removed );
     }
 

driver/src/test/java/org/neo4j/driver/internal/cluster/RoundRobinAddressSetTest.java

@@ -21,7 +21,7 @@
 import org.junit.Test;
 
 import java.util.ArrayList;
-import java.util.HashSet;
+import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Set;
 
@@ -50,7 +50,7 @@ public void shouldReturnRoundRobin() throws Exception
     {
         // given
         RoundRobinAddressSet set = new RoundRobinAddressSet();
-        Set<BoltServerAddress> addresses = new HashSet<>( asList(
+        Set<BoltServerAddress> addresses = new LinkedHashSet<>( asList(
                 new BoltServerAddress( "one" ),
                 new BoltServerAddress( "two" ),
                 new BoltServerAddress( "tre" ) ) );
@@ -78,7 +78,7 @@ public void shouldReturnRoundRobin() throws Exception
     public void shouldPreserveOrderWhenAdding() throws Exception
     {
         // given
-        HashSet<BoltServerAddress> servers = new HashSet<>( asList(
+        Set<BoltServerAddress> servers = new LinkedHashSet<>( asList(
                 new BoltServerAddress( "one" ),
                 new BoltServerAddress( "two" ),
                 new BoltServerAddress( "tre" ) ) );
@@ -119,7 +119,7 @@ public void shouldPreserveOrderWhenAdding() throws Exception
     public void shouldPreserveOrderWhenRemoving() throws Exception
     {
         // given
-        HashSet<BoltServerAddress> servers = new HashSet<>( asList(
+        Set<BoltServerAddress> servers = new LinkedHashSet<>( asList(
                 new BoltServerAddress( "one" ),
                 new BoltServerAddress( "two" ),
                 new BoltServerAddress( "tre" ) ) );
@@ -151,7 +151,7 @@ public void shouldPreserveOrderWhenRemoving() throws Exception
     public void shouldPreserveOrderWhenRemovingThroughUpdate() throws Exception
     {
         // given
-        HashSet<BoltServerAddress> servers = new HashSet<>( asList(
+        Set<BoltServerAddress> servers = new LinkedHashSet<>( asList(
                 new BoltServerAddress( "one" ),
                 new BoltServerAddress( "two" ),
                 new BoltServerAddress( "tre" ) ) );