Address PR review

Zhen Li · Zhen Li · commit 8e6dd4c4bd04 · 2018-04-06T13:48:43.000+02:00
diff --git a/driver/src/main/java/org/neo4j/driver/internal/InternalIsoDuration.java b/driver/src/main/java/org/neo4j/driver/internal/InternalIsoDuration.java
@@ -196,7 +196,7 @@ public int hashCode()
     public String toString()
     {
         // print the duration in iso standard format.
-        if ( this == ZERO )
+        if ( this.equals( ZERO ) )
         {
             return "PT0S"; // no need to allocate a string builder if we know the result
         }
diff --git a/driver/src/test/java/org/neo4j/driver/internal/InternalIsoDurationTest.java b/driver/src/test/java/org/neo4j/driver/internal/InternalIsoDurationTest.java
@@ -156,6 +156,7 @@ public void shouldCreateFromDuration()
     @Test
     public void toStringShouldPrintInIsoStandardFormat() throws Throwable
     {
+        assertThat( new InternalIsoDuration( 0, 0, 0, 0 ).toString(), equalTo( "PT0S" ) );
         assertThat( new InternalIsoDuration( Period.parse( "P356D" ) ).toString(), equalTo( "P50W6D" ) );
         assertThat( new InternalIsoDuration( Duration.parse( "PT45S" ) ).toString(), equalTo( "PT45S" ) );
 

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ public int hashCode()`
`196`	`196`	`public String toString()`
`197`	`197`	`{`
`198`	`198`	`// print the duration in iso standard format.`
`199`		`- if ( this == ZERO )`
	`199`	`+ if ( this.equals( ZERO ) )`
`200`	`200`	`{`
`201`	`201`	`return "PT0S"; // no need to allocate a string builder if we know the result`
`202`	`202`	`}`
Original file line number	Diff line number	Diff line change
`@@ -156,6 +156,7 @@ public void shouldCreateFromDuration()`
`156`	`156`	`@Test`
`157`	`157`	`public void toStringShouldPrintInIsoStandardFormat() throws Throwable`
`158`	`158`	`{`
	`159`	`+ assertThat( new InternalIsoDuration( 0, 0, 0, 0 ).toString(), equalTo( "PT0S" ) );`
`159`	`160`	`assertThat( new InternalIsoDuration( Period.parse( "P356D" ) ).toString(), equalTo( "P50W6D" ) );`
`160`	`161`	`assertThat( new InternalIsoDuration( Duration.parse( "PT45S" ) ).toString(), equalTo( "PT45S" ) );`
`161`	`162`