Deprecate liveness check timeout setting

This setting is not useful after ping is removed.

Author: lutovich

driver/src/main/java/org/neo4j/driver/internal/net/pooling/PoolSettings.java

@@ -21,38 +21,20 @@
 
 public class PoolSettings
 {
-    public static PoolSettings defaultSettings()
-    {
-        return new PoolSettings( DEFAULT_MAX_IDLE_CONNECTION_POOL_SIZE, DEFAULT_IDLE_TIME_BEFORE_CONNECTION_TEST );
-    }
-
     public static final int DEFAULT_MAX_IDLE_CONNECTION_POOL_SIZE = 10;
-    public static final long DEFAULT_IDLE_TIME_BEFORE_CONNECTION_TEST = 200;
 
     /**
      * Maximum number of idle connections per pool.
      */
     private final int maxIdleConnectionPoolSize;
 
-    /**
-     * Connections that have been idle longer than this threshold will have a ping test performed on them.
-     */
-    private final long idleTimeBeforeConnectionTest;
-
-    public PoolSettings( int maxIdleConnectionPoolSize, long idleTimeBeforeConnectionTest )
+    public PoolSettings( int maxIdleConnectionPoolSize )
     {
         this.maxIdleConnectionPoolSize = maxIdleConnectionPoolSize;
-        this.idleTimeBeforeConnectionTest = idleTimeBeforeConnectionTest;
     }
 
     public int maxIdleConnectionPoolSize()
     {
         return maxIdleConnectionPoolSize;
     }
-
-    public long idleTimeBeforeConnectionTest()
-    {
-        return idleTimeBeforeConnectionTest;
-    }
-
 }

driver/src/main/java/org/neo4j/driver/v1/Config.java

@@ -51,9 +51,6 @@ public class Config
 
     private final int maxIdleConnectionPoolSize;
 
-    /** Connections that have been idle longer than this threshold will have a ping test performed on them. */
-    private final long idleTimeBeforeConnectionTest;
-
     /** Level of encryption we need to adhere to */
     private final EncryptionLevel encryptionLevel;
 
@@ -68,7 +65,6 @@ private Config( ConfigBuilder builder)
         this.logging = builder.logging;
 
         this.maxIdleConnectionPoolSize = builder.maxIdleConnectionPoolSize;
-        this.idleTimeBeforeConnectionTest = builder.idleTimeBeforeConnectionTest;
 
         this.encryptionLevel = builder.encryptionLevel;
         this.trustStrategy = builder.trustStrategy;
@@ -107,11 +103,15 @@ public int maxIdleConnectionPoolSize()
     /**
      * Pooled connections that have been unused for longer than this timeout will be tested before they are
      * used again, to ensure they are still live.
+     *
      * @return idle time in milliseconds
+     * @deprecated pooled sessions are automatically checked for validity before being returned to the pool. This
+     * method will always return <code>-1</code> and will be possibly removed in future.
      */
+    @Deprecated
     public long idleTimeBeforeConnectionTest()
     {
-        return idleTimeBeforeConnectionTest;
+        return -1;
     }
 
     /**
@@ -159,7 +159,6 @@ public static class ConfigBuilder
     {
         private Logging logging = new JULogging( Level.INFO );
         private int maxIdleConnectionPoolSize = PoolSettings.DEFAULT_MAX_IDLE_CONNECTION_POOL_SIZE;
-        private long idleTimeBeforeConnectionTest = PoolSettings.DEFAULT_IDLE_TIME_BEFORE_CONNECTION_TEST;
         private EncryptionLevel encryptionLevel = EncryptionLevel.REQUIRED;
         private TrustStrategy trustStrategy = trustAllCertificates();
         private int routingFailureLimit = 1;
@@ -229,10 +228,12 @@ public ConfigBuilder withMaxIdleSessions( int size )
          *
          * @param timeout minimum idle time in milliseconds
          * @return this builder
+         * @deprecated pooled sessions are automatically checked for validity before being returned to the pool.
+         * This setting will be ignored and possibly removed in future.
          */
+        @Deprecated
         public ConfigBuilder withSessionLivenessCheckTimeout( long timeout )
         {
-            this.idleTimeBeforeConnectionTest = timeout;
             return this;
         }
 

driver/src/main/java/org/neo4j/driver/v1/GraphDatabase.java

@@ -177,9 +177,7 @@ public static Driver driver( URI uri, AuthToken authToken, Config config )
         }
 
         // Establish pool settings
-        PoolSettings poolSettings = new PoolSettings(
-                config.maxIdleConnectionPoolSize(),
-                config.idleTimeBeforeConnectionTest() );
+        PoolSettings poolSettings = new PoolSettings( config.maxIdleConnectionPoolSize() );
 
         // And finally, construct the driver proper
         ConnectionPool connectionPool =

driver/src/test/java/org/neo4j/driver/internal/ConfigTest.java

@@ -26,9 +26,7 @@
 import org.neo4j.driver.v1.util.FileTools;
 
 import static java.lang.System.getProperty;
-import static org.hamcrest.CoreMatchers.equalTo;
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertThat;
 
 public class ConfigTest
 {
@@ -79,13 +77,13 @@ public void shouldChangeToTrustedCert()
     }
 
     @Test
-    public void shouldConfigureMinIdleTime() throws Throwable
+    public void shouldIgnoreLivenessCheckTimeoutSetting() throws Throwable
     {
         // when
         Config config = Config.build().withSessionLivenessCheckTimeout( 1337 ).toConfig();
 
         // then
-        assertThat( config.idleTimeBeforeConnectionTest(), equalTo( 1337L ) );
+        assertEquals( -1, config.idleTimeBeforeConnectionTest() );
     }
 
     public static void deleteDefaultKnownCertFileIfExists()