test: add test for duplicated node object type ids

Author: jchen042

packages/graph-schema-utils/src/formatters/json/extensions.test.ts

@@ -14,5 +14,24 @@ describe("JSON formatter", () => {
         message: "Duplicate node label IDs found in schema",
       });
     });
+
+    test("Identifies duplicated node object types and throws an error", () => {
+      const schema = readFile(
+        path.resolve(
+          __dirname,
+          "./test-schemas/duplicated-nodeObjectType-ids.json"
+        )
+      );
+      assert.throws(() => fromJson(schema), {
+        message: "Duplicate node object type IDs found in schema",
+      });
+    });
+
+    test("Does not throw an error if there are no duplicated ids in node labels or node object types", () => {
+      const schema = readFile(
+        path.resolve(__dirname, "./test-schemas/full.json")
+      );
+      assert.doesNotThrow(() => fromJson(schema));
+    });
   });
 });

packages/graph-schema-utils/src/formatters/json/extensions.ts

@@ -123,6 +123,21 @@ export function hasDuplicateNodeLabelIds(
   return false;
 }
 
+export function hasDuplicateNodeObjectTypeIds(
+  schema: GraphSchemaJsonStruct
+): boolean {
+  const ids = new Set<string>();
+
+  for (const nodeObjectType of schema.nodeObjectTypes) {
+    if (ids.has(nodeObjectType.$id)) {
+      return true;
+    }
+    ids.add(nodeObjectType.$id);
+  }
+
+  return false;
+}
+
 export function fromJsonStruct(schemaJson: RootSchemaJsonStruct): GraphSchema {
   const { graphSchema } = schemaJson.graphSchemaRepresentation;
   console.log(graphSchema, hasDuplicateNodeLabelIds(graphSchema));
@@ -133,6 +148,9 @@ export function fromJsonStruct(schemaJson: RootSchemaJsonStruct): GraphSchema {
   const relationshipTypes = graphSchema.relationshipTypes.map(
     relationshipType.create
   );
+  if (hasDuplicateNodeObjectTypeIds(graphSchema)) {
+    throw new Error("Duplicate node object type IDs found in schema");
+  }
   const nodeObjectTypes = graphSchema.nodeObjectTypes.map(
     (nodeObjectTypeJson) =>
       nodeObjectType.create(nodeObjectTypeJson, (ref) => {

packages/graph-schema-utils/src/formatters/json/test-schemas/duplicated-nodeObjectType-ids.json

@@ -0,0 +1,123 @@
+{
+  "graphSchemaRepresentation": {
+    "version": "1.0.0",
+    "graphSchema": {
+      "nodeLabels": [
+        {
+          "$id": "nl:0",
+          "token": "DOCS_CHUNKS_TABLE",
+          "properties": [
+            {
+              "$id": "p:0_0",
+              "token": "RELATIVE_PATH",
+              "type": {
+                "type": "string"
+              },
+              "nullable": false
+            },
+            {
+              "$id": "p:0_1",
+              "token": "SIZE",
+              "type": {
+                "type": "integer"
+              },
+              "nullable": false
+            },
+            {
+              "$id": "p:0_2",
+              "token": "FILE_URL",
+              "type": {
+                "type": "string"
+              },
+              "nullable": false
+            },
+            {
+              "$id": "p:0_3",
+              "token": "SCOPED_FILE_URL",
+              "type": {
+                "type": "string"
+              },
+              "nullable": false
+            },
+            {
+              "$id": "p:0_4",
+              "token": "CHUNK",
+              "type": {
+                "type": "string"
+              },
+              "nullable": false
+            }
+          ]
+        },
+        {
+          "$id": "nl:1",
+          "token": "DOCS_METADATA",
+          "properties": [
+            {
+              "$id": "p:0_0",
+              "token": "RELATIVE_PATH",
+              "type": {
+                "type": "string"
+              },
+              "nullable": false
+            },
+            {
+              "$id": "p:0_1",
+              "token": "MODEL_NAME",
+              "type": {
+                "type": "string"
+              },
+              "nullable": false
+            },
+            {
+              "$id": "p:0_2",
+              "token": "SKILLS",
+              "type": {
+                "type": "string"
+              },
+              "nullable": false
+            },
+            {
+              "$id": "p:0_3",
+              "token": "DOMAINS",
+              "type": {
+                "type": "string"
+              },
+              "nullable": false
+            },
+            {
+              "$id": "p:0_4",
+              "token": "SUMMARY",
+              "type": {
+                "type": "string"
+              },
+              "nullable": false
+            }
+          ]
+        }
+      ],
+      "relationshipTypes": [],
+      "nodeObjectTypes": [
+        {
+          "$id": "n:0",
+          "labels": [
+            {
+              "$ref": "#nl:0"
+            }
+          ]
+        },
+        {
+          "$id": "n:0",
+          "labels": [
+            {
+              "$ref": "#nl:0"
+            }
+          ]
+        }
+      ],
+      "relationshipObjectTypes": [],
+      "constraints": [],
+      "indexes": []
+    }
+  }
+}