test: add test case for duplicated node label ids

Author: jchen042

packages/graph-schema-utils/src/formatters/json/extensions.test.ts

@@ -5,12 +5,14 @@ import { fromJson } from "./index.js";
 import { strict as assert } from "node:assert";
 
 describe("JSON formatter", () => {
-  describe("fromJsonStruct", () => {
+  describe("fromJson", () => {
     const schemaWithDuplicatedNodeLabels = readFile(
       path.resolve(__dirname, "./test-schemas/duplicated-nodeLabel-ids.json")
     );
     test("Identifies duplicated node labels adn throws an error", () => {
-      assert.throws(() => fromJson(schemaWithDuplicatedNodeLabels));
+      assert.throws(() => fromJson(schemaWithDuplicatedNodeLabels), {
+        message: "Duplicate node label IDs found in schema",
+      });
     });
   });
 });

packages/graph-schema-utils/src/formatters/json/extensions.ts

@@ -23,6 +23,7 @@ import {
 } from "../../model/index.js";
 import {
   ConstraintJsonStruct,
+  GraphSchemaJsonStruct,
   IndexJsonStruct,
   isLookupIndexJsonStruct,
   isNodeLabelConstraintJsonStruct,
@@ -107,8 +108,27 @@ export function fromJson(schema: string): GraphSchema {
   return fromJsonStruct(schemaJson);
 }
 
+export function hasDuplicateNodeLabelIds(
+  schema: GraphSchemaJsonStruct
+): boolean {
+  const ids = new Set<string>();
+
+  for (const nodeLabel of schema.nodeLabels) {
+    if (ids.has(nodeLabel.$id)) {
+      return true;
+    }
+    ids.add(nodeLabel.$id);
+  }
+
+  return false;
+}
+
 export function fromJsonStruct(schemaJson: RootSchemaJsonStruct): GraphSchema {
   const { graphSchema } = schemaJson.graphSchemaRepresentation;
+  console.log(graphSchema, hasDuplicateNodeLabelIds(graphSchema));
+  if (hasDuplicateNodeLabelIds(graphSchema)) {
+    throw new Error("Duplicate node label IDs found in schema");
+  }
   const labels = graphSchema.nodeLabels.map(nodeLabel.create);
   const relationshipTypes = graphSchema.relationshipTypes.map(
     relationshipType.create

packages/graph-schema-utils/src/formatters/json/test-schemas/duplicated-nodeLabel-ids.json

@@ -50,43 +50,43 @@
           ]
         },
         {
-          "$id": "nl:1",
+          "$id": "nl:0",
           "token": "DOCS_METADATA",
           "properties": [
             {
-              "$id": "p:1_0",
+              "$id": "p:0_0",
               "token": "RELATIVE_PATH",
               "type": {
                 "type": "string"
               },
               "nullable": false
             },
             {
-              "$id": "p:1_1",
+              "$id": "p:0_1",
               "token": "MODEL_NAME",
               "type": {
                 "type": "string"
               },
               "nullable": false
             },
             {
-              "$id": "p:1_2",
+              "$id": "p:0_2",
               "token": "SKILLS",
               "type": {
                 "type": "string"
               },
               "nullable": false
             },
             {
-              "$id": "p:1_3",
+              "$id": "p:0_3",
               "token": "DOMAINS",
               "type": {
                 "type": "string"
               },
               "nullable": false
             },
             {
-              "$id": "p:1_4",
+              "$id": "p:0_4",
               "token": "SUMMARY",
               "type": {
                 "type": "string"
@@ -107,10 +107,10 @@
           ]
         },
         {
-          "$id": "n:1",
+          "$id": "n:0",
           "labels": [
             {
-              "$ref": "#nl:1"
+              "$ref": "#nl:0"
             }
           ]
         }