Skip to content

Commit 14531e1

Browse files
committed
Address PR feedback
1 parent 132e1ad commit 14531e1

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

graphdatascience/procedure_surface/api/catalog/relationships_endpoints.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ def collapse_path(
223223
username: str | None = None,
224224
) -> CollapsePathResult:
225225
"""
226-
Collapse a path in the graph catalog.
226+
Collapse each existing path in the graph into a single relationship.
227227
228228
Parameters
229229
----------
@@ -237,9 +237,9 @@ def collapse_path(
237237
allow_self_loops : bool, default=False
238238
Whether nodes in the graph can have relationships where start and end nodes are the same.
239239
concurrency : int | None, default=None:
240-
Number of concurrent threads to use. Defaults to None.
240+
Number of concurrent threads to use.
241241
job_id : str | None, default=None
242-
Unique identifier for the job associated with the graph generation.
242+
Unique identifier for the job associated with the computation.
243243
sudo : bool | None, default=None
244244
Override memory estimation limits
245245
log_progress : bool | None, default=None

graphdatascience/procedure_surface/arrow/config_arrow_endpoints.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ def set(
3535
value: Any,
3636
username: str | None = None,
3737
) -> None:
38+
key = ConfigConverter.convert_to_camel_case(key)
3839
deserialize(self._arrow_client.do_action_with_retry("v2/defaults.set", {key: value}))
3940

4041
def list(
@@ -65,6 +66,7 @@ def set(
6566
value: Any,
6667
username: str | None = None,
6768
) -> None:
69+
key = ConfigConverter.convert_to_camel_case(key)
6870
deserialize(self._arrow_client.do_action_with_retry("v2/limits.set", {key: value}))
6971

7072
def list(

graphdatascience/procedure_surface/cypher/config_cypher_endpoints.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ def set(
3535
value: Any,
3636
username: str | None = None,
3737
) -> None:
38+
key = ConfigConverter.convert_to_camel_case(key)
39+
3840
params = {
3941
"key": key,
4042
"value": value,
@@ -75,6 +77,8 @@ def set(
7577
value: Any,
7678
username: str | None = None,
7779
) -> None:
80+
key = ConfigConverter.convert_to_camel_case(key)
81+
7882
params = {
7983
"key": key,
8084
"value": value,

graphdatascience/procedure_surface/utils/config_converter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def convert_to_gds_config(**kwargs: Any | None) -> dict[str, Any]:
1313
return config
1414

1515
@staticmethod
16-
def _convert_to_camel_case(name: str) -> str:
16+
def convert_to_camel_case(name: str) -> str:
1717
"""Convert a snake_case string to camelCase."""
1818
parts = name.split("_")
1919

@@ -29,7 +29,7 @@ def _process_dict_values(input_dict: dict[str, Any]) -> dict[str, Any]:
2929
result = {}
3030
for key, value in input_dict.items():
3131
if value is not None:
32-
camel_key = ConfigConverter._convert_to_camel_case(key)
32+
camel_key = ConfigConverter.convert_to_camel_case(key)
3333
# Recursively process nested dictionaries
3434
if isinstance(value, dict):
3535
result[camel_key] = ConfigConverter._process_dict_values(value)

0 commit comments

Comments
 (0)