Skip to content

Commit 12cc45f

Browse files
committed
Drop write-internal fields from config in stats result
1 parent f5935df commit 12cc45f

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

graphdatascience/procedure_surface/arrow/node_property_endpoints.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,10 @@ def run_job_and_get_summary(self, endpoint: str, G: GraphV2, config: dict[str, A
3434
show_progress: bool = config.get("logProgress", True) and self._show_progress
3535

3636
job_id = JobClient.run_job_and_wait(self._arrow_client, endpoint, config, show_progress)
37-
return JobClient.get_summary(self._arrow_client, job_id)
37+
result = JobClient.get_summary(self._arrow_client, job_id)
38+
if config := result.get("configuration"):
39+
self._drop_write_internals(config)
40+
return result
3841

3942
def run_job_and_mutate(
4043
self, endpoint: str, G: GraphV2, config: dict[str, Any], mutate_property: str
@@ -49,12 +52,9 @@ def run_job_and_mutate(
4952
computation_result["nodePropertiesWritten"] = mutate_result.node_properties_written
5053
computation_result["mutateMillis"] = mutate_result.mutate_millis
5154

52-
if (config := computation_result.get("configuration", None)) is not None:
55+
if config := computation_result.get("configuration"):
5356
config["mutateProperty"] = mutate_property
54-
config.pop("writeConcurrency", None)
55-
config.pop("writeToResultStore", None)
56-
config.pop("writeProperty", None)
57-
config.pop("writeMillis", None)
57+
self._drop_write_internals(config)
5858

5959
return computation_result
6060

@@ -125,3 +125,9 @@ def estimate(
125125
res = self._arrow_client.do_action_with_retry(estimate_endpoint, payload)
126126

127127
return EstimationResult(**deserialize_single(res))
128+
129+
def _drop_write_internals(self, config: dict[str, Any]) -> None:
130+
config.pop("writeConcurrency", None)
131+
config.pop("writeToResultStore", None)
132+
config.pop("writeProperty", None)
133+
config.pop("writeMillis", None)

graphdatascience/tests/integrationV2/procedure_surface/arrow/centrality/test_pagerank_arrow_endpoints.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ def test_pagerank_stats(pagerank_endpoints: PageRankArrowEndpoints, sample_graph
5959
assert result.compute_millis >= 0
6060
assert result.pre_processing_millis >= 0
6161
assert result.post_processing_millis >= 0
62+
assert "writeToResultStore" not in result.configuration
6263
assert "p50" in result.centrality_distribution
6364

6465

0 commit comments

Comments
 (0)