Write unit tests & add missing use

Author: Wout Gevaert

src/Clauses/CreateClause.php

@@ -21,6 +21,7 @@
 
 namespace WikibaseSolutions\CypherDSL\Clauses;
 
+use WikibaseSolutions\CypherDSL\Assignment;
 use WikibaseSolutions\CypherDSL\ErrorHandling\ErrorHelper;
 use WikibaseSolutions\CypherDSL\Types\StructuralTypes\StructuralType;
 

tests/Unit/Clauses/CreateClauseTest.php

@@ -25,6 +25,7 @@
 use TypeError;
 use WikibaseSolutions\CypherDSL\Clauses\CreateClause;
 use WikibaseSolutions\CypherDSL\Tests\Unit\TestHelper;
+use WikibaseSolutions\CypherDSL\Assignment;
 use WikibaseSolutions\CypherDSL\Types\AnyType;
 use WikibaseSolutions\CypherDSL\Types\StructuralTypes\NodeType;
 use WikibaseSolutions\CypherDSL\Types\StructuralTypes\PathType;
@@ -93,6 +94,19 @@ public function testAcceptsPathType()
         $createClause->toQuery();
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
+    public function testAcceptsAssignment()
+    {
+        $createClause = new CreateClause();
+
+        $patternA = $this->getQueryConvertableMock(Assignment::class, "p = (a)-->(b)");
+
+        $createClause->addPattern($patternA);
+        $createClause->toQuery();
+    }
+
     public function testDoesNotAcceptAnyType()
     {
         $createClause = new CreateClause();
@@ -104,4 +118,4 @@ public function testDoesNotAcceptAnyType()
         $createClause->addPattern($patternA);
         $createClause->toQuery();
     }
-}
+}

tests/Unit/Clauses/MatchClauseTest.php

@@ -23,6 +23,7 @@
 
 use PHPUnit\Framework\TestCase;
 use TypeError;
+use WikibaseSolutions\CypherDSL\Assignment;
 use WikibaseSolutions\CypherDSL\Clauses\MatchClause;
 use WikibaseSolutions\CypherDSL\Tests\Unit\TestHelper;
 use WikibaseSolutions\CypherDSL\Types\AnyType;
@@ -83,6 +84,18 @@ public function testAcceptsPathType()
         $match->toQuery();
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
+    public function testAcceptsAssignment()
+    {
+        $match = new MatchClause();
+
+        $match->addPattern($this->getQueryConvertableMock(Assignment::class, "p = (a)-->(b)"));
+
+        $match->toQuery();
+    }
+
     public function testDoesNotAcceptAnyType()
     {
         $this->expectException(TypeError::class);
@@ -92,4 +105,4 @@ public function testDoesNotAcceptAnyType()
 
         $match->toQuery();
     }
-}
+}

tests/Unit/Clauses/MergeClauseTest.php

@@ -23,6 +23,7 @@
 
 use PHPUnit\Framework\TestCase;
 use TypeError;
+use WikibaseSolutions\CypherDSL\Assignment;
 use WikibaseSolutions\CypherDSL\Clauses\Clause;
 use WikibaseSolutions\CypherDSL\Clauses\MergeClause;
 use WikibaseSolutions\CypherDSL\Tests\Unit\TestHelper;
@@ -121,6 +122,19 @@ public function testAcceptsPathType()
         $merge->toQuery();
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
+    public function testAcceptsAssignment()
+    {
+        $merge = new MergeClause();
+        $pattern = $this->getQueryConvertableMock(Assignment::class, "p = (a)-->(b)");
+
+        $merge->setPattern($pattern);
+
+        $merge->toQuery();
+    }
+
     public function testDoesNotAcceptAnyType()
     {
         $merge = new MergeClause();
@@ -132,4 +146,4 @@ public function testDoesNotAcceptAnyType()
 
         $merge->toQuery();
     }
-}
+}

tests/Unit/Clauses/OptionalMatchTest.php

@@ -23,6 +23,7 @@
 
 use PHPUnit\Framework\TestCase;
 use TypeError;
+use WikibaseSolutions\CypherDSL\Assignment;
 use WikibaseSolutions\CypherDSL\Clauses\OptionalMatchClause;
 use WikibaseSolutions\CypherDSL\Patterns\Pattern;
 use WikibaseSolutions\CypherDSL\Tests\Unit\TestHelper;
@@ -84,6 +85,17 @@ public function testAcceptsPathType()
         $match->toQuery();
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
+    public function testAcceptsAssignment()
+    {
+        $match = new OptionalMatchClause();
+        $match->addPattern($this->getQueryConvertableMock(Assignment::class, "p = (a)-->(b)"));
+
+        $match->toQuery();
+    }
+
     public function testDoesNotAcceptAnyType()
     {
         $match = new OptionalMatchClause();
@@ -94,4 +106,4 @@ public function testDoesNotAcceptAnyType()
 
         $match->toQuery();
     }
-}
+}

tests/Unit/QueryTest.php

@@ -226,6 +226,17 @@ public function testMatch()
         $this->assertSame("MATCH (m:Movie), (m:Movie)", $statement);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
+    public function testMatchTypeAcceptance() {
+        $assignment = $this->getQueryConvertableMock(Assignment::class, 'p = (a)-->(b)');
+        $path = $this->getQueryConvertableMock(PathType::class, '(a)-->(b)');
+        $node = $this->getQueryConvertableMock(NodeType::class, '(a)');
+
+        (new Query())->match([$assignment, $path, $node]);
+    }
+
     public function testMatchRejectsAnyType() {
         $m = $this->getQueryConvertableMock(AnyType::class, 'foo');
 
@@ -284,6 +295,17 @@ public function testCreate()
         $this->assertSame("CREATE (m:Movie)-[:RELATED]->(b), (m:Movie)-[:RELATED]->(b)", $statement);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
+    public function testCreateTypeAcceptance() {
+        $assignment = $this->getQueryConvertableMock(Assignment::class, 'p = (a)-->(b)');
+        $path = $this->getQueryConvertableMock(PathType::class, '(a)-->(b)');
+        $node = $this->getQueryConvertableMock(NodeType::class, '(a)');
+
+        (new Query())->create([$assignment, $path, $node]);
+    }
+
     public function testCreateRejectsAnyType() {
         $m = $this->getQueryConvertableMock(AnyType::class, 'foo');
 
@@ -359,6 +381,27 @@ public function testMerge()
         $this->assertSame("MERGE (m)->(b) ON CREATE DELETE (m:Movie) ON MATCH CREATE (m:Movie)", $statement);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
+    public function testMergeTypeAcceptance() {
+        $assignment = $this->getQueryConvertableMock(Assignment::class, 'p = (a)-->(b)');
+        $path = $this->getQueryConvertableMock(PathType::class, '(a)-->(b)');
+        $node = $this->getQueryConvertableMock(NodeType::class, '(a)');
+
+        (new Query())->merge($assignment);
+        (new Query())->merge($path);
+        (new Query())->merge($node);
+    }
+
+    public function testMergeRejectsAnyType() {
+        $m = $this->getQueryConvertableMock(AnyType::class, 'foo');
+
+        $this->expectException(TypeError::class);
+
+        (new Query())->optionalMatch([$m, $m]);
+    }
+
     public function testOptionalMatch()
     {
         $pattern = $this->getQueryConvertableMock(NodeType::class, "(m)");
@@ -372,8 +415,19 @@ public function testOptionalMatch()
         $this->assertSame("OPTIONAL MATCH (m), (m)", $statement);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
+    public function testOptionalMatchTypeAcceptance() {
+        $assignment = $this->getQueryConvertableMock(Assignment::class, 'p = (a)-->(b)');
+        $path = $this->getQueryConvertableMock(PathType::class, '(a)-->(b)');
+        $node = $this->getQueryConvertableMock(NodeType::class, '(a)');
+
+        (new Query())->optionalMatch([$assignment, $path, $node]);
+    }
+
     public function testOptionalMatchRejectsAnyType() {
-       $m = $this->getQueryConvertableMock(AnyType::class, 'foo');
+        $m = $this->getQueryConvertableMock(AnyType::class, 'foo');
 
         $this->expectException(TypeError::class);