working tests for bookmarks

Author: pratikshazalte69

src/Types/CypherList.php

@@ -338,9 +338,9 @@ public function getAsWGS843DPoint(int $key): WGS843DPoint
         return $this->getAsObject($key, WGS843DPoint::class);
     }
 
-    public function key(): int
+    public function key(): string
     {
-        /** @var int */
+        /** @var string */
         return $this->cacheKey();
     }
 

src/Types/CypherSequenceTrait.php

@@ -366,7 +366,7 @@ public function next(): void
 
     protected function cacheKey(): string|int
     {
-        return $this->keyCache[$this->currentPosition % max($this->cacheLimit, 1)];
+        return (string) $this->keyCache[$this->currentPosition % max($this->cacheLimit, 1)];
     }
 
     /**

testkit-backend/src/Backend.php

@@ -16,6 +16,9 @@
 use DI\ContainerBuilder;
 use Exception;
 
+use Laudis\Neo4j\Exception\Neo4jException;
+use Laudis\Neo4j\TestkitBackend\Responses\DriverErrorResponse;
+use Laudis\Neo4j\TestkitBackend\Responses\ResultResponse;
 use function get_debug_type;
 use function json_decode;
 use function json_encode;
@@ -88,11 +91,13 @@ public function handle(): void
                 continue;
             }
 
+
+            [$handler, $request] = $this->extractRequest($message);
             try {
-                [$handler, $request] = $this->extractRequest($message);
                 $this->properSendoff($handler->handle($request));
             } catch (Throwable $e) {
                 $this->logger->error($e->__toString());
+
                 $this->properSendoff(new BackendErrorResponse($e->getMessage()));
             }
         }

testkit-backend/src/Handlers/AbstractRunner.php

@@ -65,11 +65,8 @@ public function handle($request): ResultResponse
             ));
 
             return new ResultResponse($id, []);
-        } catch (\Throwable $exception) {
-                $this->repository->addRecords($id, new FrontendErrorResponse(
-                    $exception->getMessage()
-                ));
-        }
+        } // NOTE: all other exceptions will be caught in the Backend
+
         $this->repository->addRecords($id, $result);
 
         return new ResultResponse($id, $result->isEmpty() ? [] : $result->first()->keys());

testkit-backend/src/Handlers/NewSession.php

@@ -13,6 +13,7 @@
 
 namespace Laudis\Neo4j\TestkitBackend\Handlers;
 
+use Laudis\Neo4j\Databags\Bookmark;
 use Laudis\Neo4j\Databags\SessionConfiguration;
 use Laudis\Neo4j\Enum\AccessMode;
 use Laudis\Neo4j\TestkitBackend\Contracts\RequestHandlerInterface;
@@ -44,7 +45,7 @@ public function handle($request): SessionResponse
             ->withAccessMode($request->accessMode === 'r' ? AccessMode::READ() : AccessMode::WRITE());
 
         if ($request->bookmarks !== null) {
-            $config = $config->withBookmarks($request->bookmarks);
+            $config = $config->withBookmarks([new Bookmark($request->bookmarks)]);
         }
 
         if ($request->database !== null) {

testkit-backend/src/Handlers/ResultSingle.php

@@ -0,0 +1,48 @@
+<?php
+
+namespace Laudis\Neo4j\TestkitBackend\Handlers;
+
+use Laudis\Neo4j\TestkitBackend\Contracts\RequestHandlerInterface;
+use Laudis\Neo4j\TestkitBackend\Contracts\TestkitResponseInterface;
+use Laudis\Neo4j\TestkitBackend\MainRepository;
+use Laudis\Neo4j\TestkitBackend\Requests\ResultSingleRequest;
+use Laudis\Neo4j\TestkitBackend\Responses\BackendErrorResponse;
+use Laudis\Neo4j\TestkitBackend\Responses\RecordResponse;
+
+/**
+ * Request to expect and return exactly one record in the result stream.
+ *
+ * Backend should respond with a Record if exactly one record was found.
+ * If more or fewer records are left in the result stream, or if any other
+ * error occurs while retrieving the records, an Error response should be
+ * returned.
+ *
+ * @implements RequestHandlerInterface<ResultSingleRequest>
+ */
+final class ResultSingle implements RequestHandlerInterface
+{
+    private function __construct(private readonly MainRepository $repository)
+    {
+
+    }
+
+    public function handle($request): TestkitResponseInterface
+    {
+        $record = $this->repository->getRecords($request->getResultId());
+        if ($record instanceof TestkitResponseInterface) {
+            return new BackendErrorResponse('Something went wrong with the result handling');
+        }
+
+        $count = $record->count();
+        if ($count !== 1) {
+            return new BackendErrorResponse(sprintf('Found exactly %s result rows, but expected just one.', $count));
+        }
+
+        $values = [];
+        foreach ($record->getAsCypherMap(0) as $value) {
+            $values[] = $value;
+        }
+
+        return new RecordResponse($values);
+    }
+}

testkit-backend/src/Handlers/SessionBeginTransaction.php

@@ -14,11 +14,14 @@
 namespace Laudis\Neo4j\TestkitBackend\Handlers;
 
 use Laudis\Neo4j\Databags\TransactionConfiguration;
+use Laudis\Neo4j\Exception\Neo4jException;
 use Laudis\Neo4j\TestkitBackend\Contracts\RequestHandlerInterface;
 use Laudis\Neo4j\TestkitBackend\Contracts\TestkitResponseInterface;
 use Laudis\Neo4j\TestkitBackend\MainRepository;
 use Laudis\Neo4j\TestkitBackend\Requests\SessionBeginTransactionRequest;
+use Laudis\Neo4j\TestkitBackend\Responses\DriverErrorResponse;
 use Laudis\Neo4j\TestkitBackend\Responses\TransactionResponse;
+use Psr\Log\LoggerInterface;
 use Symfony\Component\Uid\Uuid;
 
 /**
@@ -27,10 +30,12 @@
 final class SessionBeginTransaction implements RequestHandlerInterface
 {
     private MainRepository $repository;
+    private LoggerInterface $logger;
 
-    public function __construct(MainRepository $repository)
+    public function __construct(MainRepository $repository, LoggerInterface $logger)
     {
         $this->repository = $repository;
+        $this->logger = $logger;
     }
 
     /**
@@ -51,7 +56,13 @@ public function handle($request): TestkitResponseInterface
         }
 
         // TODO - Create beginReadTransaction and beginWriteTransaction
-        $transaction = $session->beginTransaction(null, $config);
+        try {
+            $transaction = $session->beginTransaction(null, $config);
+        } catch (Neo4jException $exception) {
+            $this->logger->debug($exception->__toString());
+
+            return new DriverErrorResponse($request->getSessionId(), $exception);
+        }
         $id = Uuid::v4();
 
         $this->repository->addTransaction($id, $transaction);

testkit-backend/src/Handlers/SessionLastBookmarks.php

@@ -15,19 +15,38 @@
 
 use Laudis\Neo4j\TestkitBackend\Contracts\RequestHandlerInterface;
 use Laudis\Neo4j\TestkitBackend\Contracts\TestkitResponseInterface;
+use Laudis\Neo4j\TestkitBackend\MainRepository;
 use Laudis\Neo4j\TestkitBackend\Requests\SessionLastBookmarksRequest;
+use Laudis\Neo4j\TestkitBackend\Responses\BookmarksResponse;
 use Laudis\Neo4j\TestkitBackend\Responses\SkipTestResponse;
+use Monolog\Handler\AbstractHandler;
+use Symfony\Component\Uid\Uuid;
 
 /**
- * @implements RequestHandlerInterface<SessionLastBookmarksRequest>
+ * @implements AbstractRunner<SessionLastBookmarksRequest>
  */
 final class SessionLastBookmarks implements RequestHandlerInterface
 {
+    public function __construct(private readonly MainRepository $repository)
+    {
+    }
+
     /**
      * @param SessionLastBookmarksRequest $request
+     *
+     * @return TestkitResponseInterface<BookmarksResponse>
      */
     public function handle($request): TestkitResponseInterface
     {
-        return new SkipTestResponse('Bookmarks not implemented yet');
+        $session = $this->repository->getSession($request->getSessionId());
+
+        $bookmarks = $session->getLastBookmark()->values();
+
+        return new BookmarksResponse($bookmarks);
+    }
+
+    protected function getId($request): Uuid
+    {
+        return $request->getSessionId();
     }
 }

testkit-backend/src/Handlers/SessionReadTransaction.php

@@ -73,4 +73,5 @@ public function handle($request): TestkitResponseInterface
 
         return new RetryableTryResponse($id);
     }
+    // f1aa000cede64d6a8879513c97633777
 }

testkit-backend/src/Handlers/SessionWriteTransaction.php

@@ -40,21 +40,9 @@ public function handle($request): TestkitResponseInterface
     {
         $session = $this->repository->getSession($request->getSessionId());
 
-        $config = TransactionConfiguration::default();
-
-        if ($request->getTimeout()) {
-            $config = $config->withTimeout($request->getTimeout());
-        }
-
-        if ($request->getTxMeta()) {
-            $config = $config->withMetaData($request->getTxMeta());
-        }
-
-        // TODO - Create beginReadTransaction and beginWriteTransaction
-        $transaction = $session->beginTransaction(null, $config);
         $id = Uuid::v4();
 
-        $this->repository->addTransaction($id, $transaction);
+        $this->repository->addTransaction($id, $session);
         $this->repository->bindTransactionToSession($request->getSessionId(), $id);
 
         return new RetryableTryResponse($id);