Fix sorting of relations (#249)

This fix ensures that sorting relational fields will work correctly

Author: Andy2003

core/src/main/kotlin/org/neo4j/graphql/handler/projection/ProjectionBase.kt

@@ -565,9 +565,11 @@ open class ProjectionBase(
 
         val (projectionEntries, sub) = projectFields(endNodePattern, name(childVariable), field, nodeType, env, variableSuffix)
 
+        val withPassThrough = mutableListOf(endNodePattern.requiredSymbolicName)
         var relationship = relInfo.createRelation(anyNode(variable), endNodePattern)
         if (isRelFromType) {
             relationship = relationship.named(childVariableName)
+            withPassThrough.add(childVariableName)
         }
 
         val with = with(variable)
@@ -582,8 +584,8 @@ open class ProjectionBase(
             val ordering = orderBy(childVariableName, field.arguments, fieldDefinition, env.variables)
             val skipLimit = SkipLimit(childVariable, field.arguments, fieldDefinition)
             reading = when {
-                ordering != null -> skipLimit.format(reading.with(childVariableName).orderBy(*ordering.toTypedArray()))
-                skipLimit.applies() -> skipLimit.format(reading.with(childVariableName))
+                ordering != null -> skipLimit.format(reading.with(*withPassThrough.toTypedArray()).orderBy(*ordering.toTypedArray()))
+                skipLimit.applies() -> skipLimit.format(reading.with(*withPassThrough.toTypedArray()))
                 else -> reading
             }
             reading.withSubQueries(sub).returning(collect(childVariableName.project(projectionEntries)).`as`(childVariableName))

core/src/test/resources/translator-tests3.adoc

@@ -42,7 +42,7 @@ CREATE
 {user( filter: {name_in: ["Jane", "Thomas"]}) {
   name
   referredBy { referralDate referredBy {name} }
-  referred { referralDate user {name} }
+  referred(orderBy: [referralDate_desc]) { referralDate user {name} }
 } }
 ----
 
@@ -108,6 +108,7 @@ CALL {
 CALL {
 	WITH user
 	MATCH (user)<-[userReferred:REFERRED_BY]-(userReferredUser:User)
+	WITH userReferredUser, userReferred ORDER BY userReferred.referralDate DESC
 	RETURN collect(userReferred {
 		.referralDate,
 		user: userReferredUser {