テスト追加

Author: neet

package.json

@@ -15,13 +15,16 @@
     "vscode": "^1.27.0"
   },
   "dependencies": {
-    "@types/jest": "^23.3.2",
+    "@types/chai": "^4.1.5",
+    "@types/mocha": "^5.2.5",
     "@types/node": "^10.10.1",
+    "@types/sinon": "^5.0.2",
+    "chai": "^4.1.2",
     "core-js": "^2.5.7",
     "fuse.js": "^3.2.1",
-    "jest": "^23.6.0",
+    "mocha": "^5.2.0",
     "qiita-js-2": "^1.2.5",
-    "ts-jest": "^23.1.4",
+    "sinon": "^6.3.4",
     "tslint": "^5.8.0",
     "typescript": "^3.0.3",
     "vscode": "^1.1.6",

src/quickpicks/tagQuickPickCreator.ts

@@ -1,3 +1,4 @@
+import { SearchTagResult } from 'qiita-js-2';
 import { QuickPickItem, window } from 'vscode';
 import { client } from '../client';
 
@@ -12,26 +13,38 @@ export const makeQuickPickItemFromTag = (id: string, followersCount: number) =>
   description: `${followersCount}件の投稿`,
 });
 
+/**
+ * ユーザーからの入力が検索結果に無いときにその入力を結果の先頭に挿入
+ * @param value ユーザーの入力
+ * @param suggestions 検索結果
+ * @return フォーマットされた検索結果
+ */
+export const insertInputRaw = (value: string, suggestions: SearchTagResult[]) => {
+  if (!value) {
+    return suggestions;
+  }
+
+  if (suggestions
+    .map((tag) => tag.name)
+    .map((name) => RegExp(name, 'i').test(value))
+    .includes(true)) {
+    return suggestions;
+  }
+
+  suggestions.unshift({ name: value, url_name: value, follower_count: 0, item_count: 0 });
+
+  return suggestions;
+};
+
 /**
  * キーワードからタグを検索して QuickPickItem の形で返します
  * @param value キーワード
  * @return QuickPickItem
  */
-async function suggestTags (value: string) {
+export async function suggestTags (value: string): Promise<QuickPickItem[]> {
   const results = (await client.searchTags(value)).slice(0, 9);
-
-  // キーワードに相当するタグがまだ作成されていない場合、候補の一件目にそのタグを挿入
-  // tag.nameをケースインセンシティブで比較
-  if (value && !results.map((tag) => tag.name).map((name) => RegExp(name, 'i').test(value)).includes(true)) {
-    results.unshift({
-      name: value,
-      url_name: value,
-      follower_count: 0,
-      item_count: 0,
-    });
-  }
-
-  return results.map((tag) => makeQuickPickItemFromTag(tag.name, tag.follower_count));
+  const formattedResults = insertInputRaw(value, results);
+  return formattedResults.map((tag) => makeQuickPickItemFromTag(tag.name, tag.follower_count));
 }
 
 /**

src/test/commands.ts/compose.test.ts

@@ -0,0 +1,10 @@
+import { expect } from 'chai';
+import { getFilenameFromPath } from '../../commands/compose';
+
+describe('compose', () => {
+  it('パスから拡張子を除いたファイル名を取得', () => {
+    const path = 'file:///test.md';
+    const result = getFilenameFromPath(path);
+    expect(result).to.be.equal('test');
+  });
+});

src/test/index.ts

@@ -0,0 +1,22 @@
+//
+// PLEASE DO NOT MODIFY / DELETE UNLESS YOU KNOW WHAT YOU ARE DOING
+//
+// This file is providing the test runner to use when running extension tests.
+// By default the test runner in use is Mocha based.
+//
+// You can provide your own test runner if you want to override it by exporting
+// a function run(testRoot: string, clb: (error:Error) => void) that the extension
+// host can call to run the tests. The test runner is expected to use console.log
+// to report the results back to the caller. When the tests are finished, return
+// a possible error to the callback or null if none.
+
+import * as testRunner from 'vscode/lib/testrunner';
+
+// You can directly control Mocha options by uncommenting the following lines
+// See https://github.com/mochajs/mocha/wiki/Using-mocha-programmatically#set-options for more info
+testRunner.configure({
+  ui: 'bdd', 		// the TDD UI is being used in extension.test.ts (suite, test, etc.)
+  useColors: true, // colored output from test results
+});
+
+module.exports = testRunner;

src/test/quickpicks/tagsQuickPickCreator.test.ts

@@ -0,0 +1,23 @@
+import { expect } from 'chai';
+import { insertInputRaw, makeQuickPickItemFromTag } from '../../quickpicks/tagQuickPickCreator';
+
+describe('tagQuickPickCreator', () => {
+  it('渡されたIDと文字列からQuickPickItemを返す', () => {
+    const quickPickItem = makeQuickPickItemFromTag('apple', 12345);
+
+    expect(quickPickItem).to.deep.equal({
+      label: 'apple',
+      description: '12345件の投稿',
+    });
+  });
+
+  it('渡されたキーワードが検索結果に無いときに検索結果の先頭に挿入', async () => {
+    const result = insertInputRaw('apple', [
+      { name: 'google',    url_name: 'google',    follower_count: 1, item_count: 1 },
+      { name: 'facebook',  url_name: 'facebook',  follower_count: 2, item_count: 2 },
+      { name: 'microsoft', url_name: 'microsoft', follower_count: 3, item_count: 2 },
+    ]);
+
+    expect(result).to.deep.include({ name: 'apple', url_name: 'apple', follower_count: 0, item_count: 0});
+  });
+});

src/test/quickpicks/titleInputBoxCreator.test.ts

@@ -0,0 +1,15 @@
+import { expect } from 'chai';
+import { titleInputBoxCreator } from '../../quickpicks/titleInputBoxCreator';
+
+describe('titleInputBoxCreator', () => {
+  it('デフォルトの値を指定してInputBoxを作成', () => {
+    const inputBox = titleInputBoxCreator('タイトルです');
+    expect(inputBox.value).to.be.equal('タイトルです');
+  });
+
+  // 値を直接変更したらonDidChangeValueが呼ばれないみたいです >_<
+  // it('255文字以上の際に警告を表示', () => {
+  //   const inputBox = titleInputBoxCreator('0123456789'.repeat(26));
+  //   expect(inputBox.validationMessage).to.be.a('string');
+  // });
+});

src/test/utils/createMultiStepInput.test.ts

@@ -0,0 +1,16 @@
+import { expect } from 'chai';
+import { fake } from 'sinon';
+import { QuickPick } from 'vscode';
+import { createMultiStepInput } from '../../utils/createMultiStepInput';
+
+describe('createMultiStepInput', () => {
+  it('複数のQuickPick/InputBoxをラップして最初の1つを呼び出す関数を返す', () => {
+    const onDidAccept = fake();
+    const show        = fake();
+    const quickPick   = { onDidAccept, show } as any as QuickPick<any>;
+
+    createMultiStepInput([quickPick])();
+
+    expect(show.calledOnce).to.be.ok;
+  });
+});