Forward shutdown exceptions to user error handlers

Fixes phpGH-10695
Closes GH-110905

Author: iluuu1994

UPGRADING

@@ -107,6 +107,7 @@ PHP 8.3 UPGRADE NOTES
     longer accepts paths containing the parent directory (`..`). Previously,
     only paths starting with `..` were disallowed. This could easily be
     circumvented by prepending `./` to the path.
+  . User exception handlers now catch exceptions during shutdown.
 
 - Dom:
   . Changed DOMCharacterData::appendData() tentative return type to true.

Zend/Optimizer/zend_func_infos.h

@@ -689,6 +689,7 @@ static const func_info_t func_infos[] = {
 	F1("serialize", MAY_BE_STRING),
 	F1("xml_error_string", MAY_BE_STRING|MAY_BE_NULL),
 	F1("xml_parser_get_option", MAY_BE_STRING|MAY_BE_LONG|MAY_BE_BOOL),
+	FN("zend_test_create_throwing_resource", MAY_BE_RESOURCE),
 	FN("zip_open", MAY_BE_RESOURCE|MAY_BE_LONG|MAY_BE_FALSE),
 	FN("zip_read", MAY_BE_RESOURCE|MAY_BE_FALSE),
 	F1("ob_gzhandler", MAY_BE_STRING|MAY_BE_FALSE),

Zend/tests/gh10695_1.phpt

@@ -0,0 +1,16 @@
+--TEST--
+GH-10695: Exceptions in register_shutdown_function() are caught by set_exception_handler()
+--FILE--
+<?php
+set_exception_handler(function (\Throwable $exception) {
+    echo 'Caught: ' . $exception->getMessage() . "\n";
+});
+
+register_shutdown_function(function () {
+    echo "register_shutdown_function()\n";
+    throw new \Exception('shutdown');
+});
+?>
+--EXPECT--
+register_shutdown_function()
+Caught: shutdown

Zend/tests/gh10695_2.phpt

@@ -0,0 +1,18 @@
+--TEST--
+GH-10695: Exceptions in destructor during shutdown are caught
+--FILE--
+<?php
+class Foo {
+    public function __destruct() {
+        throw new \Exception(__METHOD__);
+    }
+}
+
+set_exception_handler(function (\Throwable $exception) {
+    echo 'Caught: ' . $exception->getMessage() . "\n";
+});
+
+const FOO = new Foo;
+?>
+--EXPECT--
+Caught: Foo::__destruct

Zend/tests/gh10695_3.phpt

@@ -0,0 +1,19 @@
+--TEST--
+GH-10695: Uncaught exceptions are not caught again
+--FILE--
+<?php
+register_shutdown_function(function () {
+    echo "shutdown\n";
+    set_exception_handler(function (\Throwable $exception) {
+        echo 'Caught: ' . $exception->getMessage() . "\n";
+    });
+});
+
+throw new \Exception('main');
+?>
+--EXPECTF--
+Fatal error: Uncaught Exception: main in %s:%d
+Stack trace:
+#0 {main}
+  thrown in %s on line %d
+shutdown

Zend/tests/gh10695_4.phpt

@@ -0,0 +1,19 @@
+--TEST--
+GH-10695: Exception handlers are not called twice
+--FILE--
+<?php
+set_exception_handler(function (\Throwable $exception) {
+    echo 'Caught: ' . $exception->getMessage() . "\n";
+    throw new \Exception('exception handler');
+});
+
+throw new \Exception('main');
+?>
+--EXPECTF--
+Caught: main
+
+Fatal error: Uncaught Exception: exception handler in %s:%d
+Stack trace:
+#0 [internal function]: {closure}(Object(Exception))
+#1 {main}
+  thrown in %s on line %d

Zend/tests/gh10695_5.phpt

@@ -0,0 +1,17 @@
+--TEST--
+GH-10695: Exception handlers can register another exception handler
+--FILE--
+<?php
+set_exception_handler(function (\Throwable $exception) {
+    echo 'Caught: ' . $exception->getMessage() . "\n";
+    set_exception_handler(function (\Throwable $exception) {
+        echo 'Caught: ' . $exception->getMessage() . "\n";
+    });
+    throw new \Exception('exception handler');
+});
+
+throw new \Exception('main');
+?>
+--EXPECT--
+Caught: main
+Caught: exception handler

Zend/tests/gh10695_6.phpt

@@ -0,0 +1,14 @@
+--TEST--
+GH-10695: Exceptions from output buffering handlers during shutdown are caught
+--FILE--
+<?php
+set_exception_handler(function (\Throwable $exception) {
+    echo 'Caught: ' . $exception->getMessage() . "\n";
+});
+
+ob_start(function () {
+    throw new \Exception('ob_start');
+});
+?>
+--EXPECT--
+Caught: ob_start

Zend/tests/gh10695_7.phpt

@@ -0,0 +1,16 @@
+--TEST--
+GH-10695: Exceptions in error handlers during shutdown are caught
+--FILE--
+<?php
+set_exception_handler(function (\Throwable $exception) {
+    echo 'Caught: ' . $exception->getMessage() . "\n";
+});
+set_error_handler(function ($errno, $errstr) {
+    throw new \Exception($errstr);
+});
+register_shutdown_function(function () {
+    trigger_error('main', E_USER_ERROR);
+});
+?>
+--EXPECT--
+Caught: main

Zend/zend.c

@@ -1819,6 +1819,7 @@ ZEND_API ZEND_COLD void zend_user_exception_handler(void) /* {{{ */
 	EG(exception) = NULL;
 	ZVAL_OBJ(&params[0], old_exception);
 	ZVAL_COPY_VALUE(&orig_user_exception_handler, &EG(user_exception_handler));
+	ZVAL_UNDEF(&EG(user_exception_handler));
 
 	if (call_user_function(CG(function_table), NULL, &orig_user_exception_handler, &retval2, 1, params) == SUCCESS) {
 		zval_ptr_dtor(&retval2);
@@ -1830,6 +1831,8 @@ ZEND_API ZEND_COLD void zend_user_exception_handler(void) /* {{{ */
 	} else {
 		EG(exception) = old_exception;
 	}
+
+	zval_ptr_dtor(&orig_user_exception_handler);
 } /* }}} */
 
 ZEND_API zend_result zend_execute_scripts(int type, zval *retval, int file_count, ...) /* {{{ */