Note that we know what we are doing around comparisons

ndmitchell · facebook-github-bot · commit d625dfd40048 · 2023-07-05T07:08:22.000-07:00
Summary: Ignore clippy, because this is only a warning for some types of I.

Reviewed By: JakobDegen

Differential Revision: D47226539

fbshipit-source-id: fd248d9dede1e1d52beb39b825cfdbedacdcceed
diff --git a/starlark/src/values/types/inline_int.rs b/starlark/src/values/types/inline_int.rs
@@ -190,6 +190,8 @@ impl InlineInt {
         i32: TryFrom<I>,
     {
         let i = i32::try_from(i).ok().ok_or(InlineIntOverflow)?;
+        // Only absurd for certain bit widths
+        #[allow(clippy::absurd_extreme_comparisons)]
         if hint::likely(i >= Self::MIN.0 && i <= Self::MAX.0) {
             Ok(InlineInt(i))
         } else {

Original file line number	Diff line number	Diff line change
`@@ -190,6 +190,8 @@ impl InlineInt {`
`190`	`190`	`i32: TryFrom<I>,`
`191`	`191`	`{`
`192`	`192`	`let i = i32::try_from(i).ok().ok_or(InlineIntOverflow)?;`
	`193`	`+ // Only absurd for certain bit widths`
	`194`	`+ #[allow(clippy::absurd_extreme_comparisons)]`
`193`	`195`	`if hint::likely(i >= Self::MIN.0 && i <= Self::MAX.0) {`
`194`	`196`	`Ok(InlineInt(i))`
`195`	`197`	`} else {`