chore: autofix lint issues

NathanWalker · NathanWalker · commit dd89f450cd1b · 2021-03-27T13:34:39.000-07:00
diff --git a/src/activityindicator/index.ios.ts b/src/activityindicator/index.ios.ts
@@ -76,12 +76,12 @@ export class ActivityIndicator extends ActivityIndicatorBase {
     // }
 
     [colorProperty.setNative](value: UIColor | Color) {
-        const color = value instanceof Color ? value.ios : value;;
+        const color = value instanceof Color ? value.ios : value;
         this.nativeViewProtected.cycleColors  = color ? NSArray.arrayWithObject(color) : null;
         // this.getColorThemer().primaryColor = value instanceof Color ? value.ios : value;
         // MDCActivityIndicatorColorThemer.applySemanticColorSchemeToActivityIndicator(this.getColorThemer(), this.nativeViewProtected);
     }
     [indeterminateProperty.setNative](value: boolean) {
-        this.nativeViewProtected.indicatorMode = !!value ? MDCActivityIndicatorMode.Indeterminate : MDCActivityIndicatorMode.Determinate;
+        this.nativeViewProtected.indicatorMode = value ? MDCActivityIndicatorMode.Indeterminate : MDCActivityIndicatorMode.Determinate;
     }
 }
diff --git a/src/bottom-navigation/index.android.ts b/src/bottom-navigation/index.android.ts
@@ -243,7 +243,7 @@ function iterateIndexRange(index: number, eps: number, lastIndex: number, callba
 @CSSType('BottomNavigation')
 export class BottomNavigation extends TabNavigationBase {
     private _contentView: org.nativescript.widgets.ContentLayout;
-    private _contentViewId: number = -1;
+    private _contentViewId = -1;
     private _bottomNavigationBar: org.nativescript.widgets.BottomNavigationBar;
     private _currentFragment: androidx.fragment.app.Fragment;
     private _currentTransaction: androidx.fragment.app.FragmentTransaction;
diff --git a/src/bottom-navigation/index.ios.ts b/src/bottom-navigation/index.ios.ts
@@ -416,7 +416,7 @@ export class BottomNavigation extends TabNavigationBase {
         }
     }
 
-    private setIconColor(tabStripItem: TabStripItem, forceReload: boolean = false): void {
+    private setIconColor(tabStripItem: TabStripItem, forceReload = false): void {
         if (forceReload || (!this._unSelectedItemColor && !this._selectedItemColor)) {
             // if selectedItemColor or unSelectedItemColor is set we don't respect the color from the style
             const tabStripColor = this.selectedIndex === tabStripItem._index ? this._selectedItemColor : this._unSelectedItemColor;
diff --git a/src/bottomnavigationbar/bottomnavigationbar-common.ts b/src/bottomnavigationbar/bottomnavigationbar-common.ts
@@ -57,7 +57,7 @@ export abstract class BottomNavigationBarBase extends View {
     @cssProperty badgeColor: Color;
     @cssProperty badgeTextColor: Color;
 
-    selectedTabIndex: number = 0;
+    selectedTabIndex = 0;
     titleVisibility: TitleVisibility = TitleVisibility.always;
 
     protected _items: BottomNavigationTabBase[] = [];
diff --git a/src/bottomsheet/angular/bottomsheet.module.ts b/src/bottomsheet/angular/bottomsheet.module.ts
@@ -6,7 +6,7 @@ import { install } from '@nativescript-community/ui-material-bottomsheet';
 @NgModule()
 export class NativeScriptMaterialBottomSheetModule {
     // This flag help us to avoid problems when using the new development workflow
-    private static initialized: boolean = false;
+    private static initialized = false;
 
     static forRoot(): ModuleWithProviders<NativeScriptMaterialBottomSheetModule> {
         return {
diff --git a/src/button/button-common.ts b/src/button/button-common.ts
@@ -4,7 +4,7 @@ import { VerticalTextAlignment } from '@nativescript-community/text';
 
 @CSSType('MDButton')
 export abstract class ButtonBase extends Button {
-    public variant: string = 'contained';
+    public variant = 'contained';
     @cssProperty elevation: number;
     @cssProperty dynamicElevationOffset: number;
     @cssProperty rippleColor: Color;
diff --git a/src/core/index.android.ts b/src/core/index.android.ts
@@ -177,8 +177,8 @@ export function getRippleColor(color: string | Color) {
 }
 
 class ViewWithElevationAndRipple extends View {
-    @cssProperty elevation: number = 0;
-    @cssProperty dynamicElevationOffset: number = 0;
+    @cssProperty elevation = 0;
+    @cssProperty dynamicElevationOffset = 0;
     @cssProperty rippleColor: Color;
     rippleDrawable: android.graphics.drawable.Drawable;
     getRippleColor() {
diff --git a/src/core/index.common.ts b/src/core/index.common.ts
@@ -30,9 +30,9 @@ export function applyMixins(
                 } else {
                     derivedCtor.prototype[name] = function (...args) {
                         if (options) {
-                            if (!!options.override) {
+                            if (options.override) {
                                 return baseCtor.prototype[name].apply(this, args);
-                            } else if (!!options.after) {
+                            } else if (options.after) {
                                 oldImpl.apply(this, args);
                                 return baseCtor.prototype[name].apply(this, args);
                             } else {
@@ -57,9 +57,9 @@ export function applyMixins(
             } else {
                 derivedCtor.prototype[symbol] = function (...args) {
                     if (options) {
-                        if (!!options.override) {
+                        if (options.override) {
                             return baseCtor.prototype[symbol].apply(this, args);
-                        } else if (!!options.after) {
+                        } else if (options.after) {
                             oldImpl.apply(this, args);
                             return baseCtor.prototype[symbol].apply(this, args);
                         } else {
diff --git a/src/dialogs/dialogs.android.ts b/src/dialogs/dialogs.android.ts
@@ -397,7 +397,7 @@ export function prompt(arg: any): Promise<PromptResult> {
             );
 
             showDialog(dlg, options);
-            if (!!options.autoFocus) {
+            if (options.autoFocus) {
                 textField.requestFocus();
             }
         } catch (ex) {
@@ -462,7 +462,7 @@ export function login(arg: any): Promise<LoginResult> {
 
             const alert = createAlertDialogBuilder(options);
 
-            if (!!options.beforeShow) {
+            if (options.beforeShow) {
                 options.beforeShow(options, userNameTextField, passwordTextField);
             }
             const dlg = prepareAndCreateAlertDialog(
@@ -478,7 +478,7 @@ export function login(arg: any): Promise<LoginResult> {
                 (r) => ({ result: r, userName: userNameTextField.text, password: passwordTextField.text })
             );
             showDialog(dlg, options);
-            if (!!options.autoFocus) {
+            if (options.autoFocus) {
                 userNameTextField.requestFocus();
             }
         } catch (ex) {
diff --git a/src/dialogs/dialogs.ios.ts b/src/dialogs/dialogs.ios.ts
@@ -419,7 +419,7 @@ export function prompt(arg: any): Promise<PromptResult> {
                 },
                 (r) => ({ result: r, text: textField.text })
             );
-            if (!!options.autoFocus) {
+            if (options.autoFocus) {
                 alertController.autoFocusTextField = textField;
             }
             showUIAlertController(alertController);
@@ -496,11 +496,11 @@ export function login(arg: any): Promise<LoginResult> {
                 (r) => ({ result: r, userName: userNameTextField.text, password: passwordTextField.text })
             );
 
-            if (!!options.beforeShow) {
+            if (options.beforeShow) {
                 options.beforeShow(options, userNameTextField, passwordTextField);
             }
             showUIAlertController(alertController);
-            if (!!options.autoFocus) {
+            if (options.autoFocus) {
                 alertController.autoFocusTextField = userNameTextField;
             }
         } catch (ex) {
diff --git a/src/snackbar/snackbar.ios.ts b/src/snackbar/snackbar.ios.ts
@@ -121,7 +121,7 @@ export class SnackBar extends SnackBarBase {
 
     public dismiss(): Promise<any> {
         return new Promise((resolve, reject) => {
-            if (!!SnackBar._snackbarManager) {
+            if (SnackBar._snackbarManager) {
                 try {
                     SnackBar._snackbarManager.dismissAndCallCompletionBlocksWithCategory(null);
                     this._dismissReason = DismissReasons.MANUAL;
diff --git a/src/speeddial/index.ts b/src/speeddial/index.ts
@@ -95,7 +95,7 @@ export class SpeedDialButton extends SpeedDialItemButton {}
 
 @CSSType('MDSpeedDialItem')
 export class SpeedDialItem extends SpeedDialItemBase {
-    public actualActive: boolean = false;
+    public actualActive = false;
     titleView: SpeedDialItemTitle;
     button: SpeedDialItemButton;
     fabmenu: WeakRef<SpeedDial>;
diff --git a/src/tabs/tabs.android.ts b/src/tabs/tabs.android.ts
@@ -362,7 +362,7 @@ export class Tabs extends TabsBase {
     private _tabsBar: org.nativescript.widgets.TabsBar;
     private _viewPager: org.nativescript.widgets.TabViewPager;
     private _pagerAdapter: androidx.viewpager.widget.PagerAdapter;
-    private _androidViewId: number = -1;
+    private _androidViewId = -1;
     public _originalBackground: any;
     private _textTransform: Enums.TextTransformType = 'uppercase';
     private _selectedItemColor: Color;
diff --git a/src/tabs/tabs.ios.ts b/src/tabs/tabs.ios.ts
@@ -970,7 +970,7 @@ export class Tabs extends TabsBase {
         }
     }
 
-    private setIconColor(tabStripItem: TabStripItem, forceReload: boolean = false): void {
+    private setIconColor(tabStripItem: TabStripItem, forceReload = false): void {
         // if there is no change in the css color and there is no item color set
         // we don't need to reload the icon
         if (!forceReload && !this._selectedItemColor && !this._unSelectedItemColor) {
@@ -1210,7 +1210,7 @@ export class Tabs extends TabsBase {
     //     this.viewController.tabBar.alignment = alignment;
     // }
 
-    private setViewTextAttributes(view: View, setSelected: boolean = false): any {
+    private setViewTextAttributes(view: View, setSelected = false): any {
         if (!view) {
             return null;
         }
diff --git a/src/textfield/textfield.android.ts b/src/textfield/textfield.android.ts
@@ -184,10 +184,10 @@ export class TextField extends TextFieldBase {
     }
 
     [helperProperty.setNative](value: string) {
-        (this.layoutView as any).setHelperText(!!value ? value : null);
+        (this.layoutView as any).setHelperText(value ? value : null);
     }
     [errorProperty.setNative](value: string) {
-        this.layoutView.setError(!!value ? value : null);
+        this.layoutView.setError(value ? value : null);
         this.layoutView.setErrorEnabled(!!value);
     }
 
diff --git a/src/textfield/textfield.common.ts b/src/textfield/textfield.common.ts
@@ -15,7 +15,7 @@ export abstract class TextFieldBase extends NTextField {
     @cssProperty helperColor: Color;
     @cssProperty counterMaxLength: number;
     @cssProperty errorColor: Color;
-    @cssProperty floating: boolean = true;
+    @cssProperty floating = true;
     @cssProperty placeholderColor: Color;
     @cssProperty variant: 'outline' | 'underline' | 'filled' | 'none' = 'filled';
     @cssProperty error: string;
diff --git a/src/textview/textview.android.ts b/src/textview/textview.android.ts
@@ -192,10 +192,10 @@ export class TextView extends TextViewBase {
     }
 
     [helperProperty.setNative](value: string) {
-        (this.layoutView as any).setHelperText(!!value ? value : null);
+        (this.layoutView as any).setHelperText(value ? value : null);
     }
     [errorProperty.setNative](value: string) {
-        this.layoutView.setError(!!value ? value : null);
+        this.layoutView.setError(value ? value : null);
         this.layoutView.setErrorEnabled(!!value);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -76,12 +76,12 @@ export class ActivityIndicator extends ActivityIndicatorBase {`
`76`	`76`	`// }`
`77`	`77`
`78`	`78`	`[colorProperty.setNative](value: UIColor \| Color) {`
`79`		`- const color = value instanceof Color ? value.ios : value;;`
	`79`	`+ const color = value instanceof Color ? value.ios : value;`
`80`	`80`	`this.nativeViewProtected.cycleColors = color ? NSArray.arrayWithObject(color) : null;`
`81`	`81`	`// this.getColorThemer().primaryColor = value instanceof Color ? value.ios : value;`
`82`	`82`	`// MDCActivityIndicatorColorThemer.applySemanticColorSchemeToActivityIndicator(this.getColorThemer(), this.nativeViewProtected);`
`83`	`83`	`}`
`84`	`84`	`[indeterminateProperty.setNative](value: boolean) {`
`85`		`- this.nativeViewProtected.indicatorMode = !!value ? MDCActivityIndicatorMode.Indeterminate : MDCActivityIndicatorMode.Determinate;`
	`85`	`+ this.nativeViewProtected.indicatorMode = value ? MDCActivityIndicatorMode.Indeterminate : MDCActivityIndicatorMode.Determinate;`
`86`	`86`	`}`
`87`	`87`	`}`
Original file line number	Diff line number	Diff line change
`@@ -416,7 +416,7 @@ export class BottomNavigation extends TabNavigationBase {`
`416`	`416`	`}`
`417`	`417`	`}`
`418`	`418`
`419`		`- private setIconColor(tabStripItem: TabStripItem, forceReload: boolean = false): void {`
	`419`	`+ private setIconColor(tabStripItem: TabStripItem, forceReload = false): void {`
`420`	`420`	`if (forceReload \|\| (!this._unSelectedItemColor && !this._selectedItemColor)) {`
`421`	`421`	`// if selectedItemColor or unSelectedItemColor is set we don't respect the color from the style`
`422`	`422`	`const tabStripColor = this.selectedIndex === tabStripItem._index ? this._selectedItemColor : this._unSelectedItemColor;`