fix(android): potential memory leaks fix

Author: farfromrefug

src/bottomnavigationbar/bottomnavigationbar.android.ts

@@ -16,7 +16,7 @@ declare type OnNavigationItemSelectedListener = com.google.android.material.bott
 declare type OnNavigationItemReselectedListener = com.google.android.material.bottomnavigation.BottomNavigationView.OnNavigationItemReselectedListener;
 
 // Listeners
-type OnTabSelectedlistener = new (owner: BottomNavigationBar) => OnNavigationItemSelectedListener;
+type OnTabSelectedlistener = new (owner: WeakRef<BottomNavigationBar>) => OnNavigationItemSelectedListener;
 
 // eslint-disable-next-line no-redeclare
 let OnTabSelectedlistener: OnTabSelectedlistener;
@@ -29,24 +29,26 @@ const getOnTabSelectedlistener = () => {
     @NativeClass
     @Interfaces([com.google.android.material.bottomnavigation.BottomNavigationView.OnNavigationItemSelectedListener])
     class OnTabSelectedlistenerImpl extends java.lang.Object implements OnNavigationItemSelectedListener {
-        constructor(public owner: BottomNavigationBar) {
+        constructor(public owner: WeakRef<BottomNavigationBar>) {
             super();
-
             // necessary when extending TypeScript constructors
             return global.__native(this);
         }
 
         public onNavigationItemSelected(menuItem: globalAndroid.view.MenuItem): boolean {
-            const index = menuItem.getItemId();
-            const bottomNavigationTab = this.owner.items[index];
-
-            if (bottomNavigationTab.isSelectable) {
-                this.owner._emitTabSelected(index);
-            } else {
-                this.owner._emitTabPressed(index);
+            const owner = this.owner?.get();
+            if (owner) {
+                const index = menuItem.getItemId();
+                const bottomNavigationTab = owner.items[index];
+
+                if (bottomNavigationTab.isSelectable) {
+                    owner._emitTabSelected(index);
+                } else {
+                    owner._emitTabPressed(index);
+                }
+                return bottomNavigationTab.isSelectable;
             }
-
-            return bottomNavigationTab.isSelectable;
+            return false;
         }
     }
 
@@ -55,7 +57,7 @@ const getOnTabSelectedlistener = () => {
     return OnTabSelectedlistener;
 };
 
-type OnTabReselectedListener = new (owner: BottomNavigationBar) => OnNavigationItemReselectedListener;
+type OnTabReselectedListener = new (owner: WeakRef<BottomNavigationBar>) => OnNavigationItemReselectedListener;
 
 // eslint-disable-next-line no-redeclare
 let OnTabReselectedListener: OnTabReselectedListener;
@@ -67,15 +69,14 @@ const getOnTabReselectedListener = () => {
     @NativeClass
     @Interfaces([com.google.android.material.bottomnavigation.BottomNavigationView.OnNavigationItemReselectedListener])
     class OnTabReselectedListenerImpl extends java.lang.Object implements OnNavigationItemReselectedListener {
-        constructor(public owner: BottomNavigationBar) {
+        constructor(public owner: WeakRef<BottomNavigationBar>) {
             super();
-
             // necessary when extending TypeScript constructors
             return global.__native(this);
         }
 
         public onNavigationItemReselected(menuItem: globalAndroid.view.MenuItem): void {
-            this.owner._emitTabReselected(menuItem.getItemId());
+            this.owner?.get()?._emitTabReselected(menuItem.getItemId());
         }
     }
 
@@ -115,8 +116,9 @@ export class BottomNavigationBar extends BottomNavigationBarBase {
         super.initNativeView();
         const OnTabReselectedListener = getOnTabReselectedListener();
         const OnTabSelectedListener = getOnTabSelectedlistener();
-        this.reselectListener = new OnTabReselectedListener(this);
-        this.selectListener = new OnTabSelectedListener(this);
+        const that = new WeakRef(this);
+        this.reselectListener = new OnTabReselectedListener(that);
+        this.selectListener = new OnTabSelectedListener(that);
         this.nativeViewProtected.setOnNavigationItemReselectedListener(this.reselectListener);
         this.nativeViewProtected.setOnNavigationItemSelectedListener(this.selectListener);
         // Create the tabs before setting the default values for each tab

src/bottomsheet/bottomsheet.android.ts

@@ -18,31 +18,30 @@ function getId(id: string) {
 
 @NativeClass
 class ChangeStateBottomSheet extends com.google.android.material.bottomsheet.BottomSheetBehavior.BottomSheetCallback {
-    private owner: ViewWithBottomSheet;
-
-    constructor(owner: ViewWithBottomSheet) {
+    constructor(private owner: WeakRef<ViewWithBottomSheet>) {
         super();
-        this.owner = owner;
         return global.__native(this);
     }
 
     onSlide(bottomSheet: android.view.View, slideOffset: number) {
-        if (this.checkActiveCallback()) {
-            this.owner._onChangeStateBottomSheetCallback(StateBottomSheet.DRAGGING, slideOffset);
+        const owner = this.owner?.get();
+        if (owner && this.checkActiveCallback()) {
+            owner._onChangeStateBottomSheetCallback(StateBottomSheet.DRAGGING, slideOffset);
         }
     }
 
     onStateChanged(bottomSheet: android.view.View, newState: number) {
-        if (this.checkActiveCallback()) {
+        const owner = this.owner?.get();
+        if (owner && this.checkActiveCallback()) {
             const status = this.getStateBottomSheetFromBottomSheetBehavior(newState);
             if (status !== undefined) {
-                this.owner._onChangeStateBottomSheetCallback(status);
+                owner._onChangeStateBottomSheetCallback(status);
             }
         }
     }
 
     private checkActiveCallback() {
-        return this.owner && this.owner._onChangeStateBottomSheetCallback;
+        return this.owner?.get()?._onChangeStateBottomSheetCallback;
     }
 
     public getStateBottomSheetFromBottomSheetBehavior(state: number): StateBottomSheet | undefined {
@@ -77,7 +76,7 @@ export class ViewWithBottomSheet extends ViewWithBottomSheetBase {
 
     protected _showNativeBottomSheet(parent: View, options: BottomSheetOptions) {
         this._commonShowNativeBottomSheet(parent, options);
-        const owner = this;
+        const that = new WeakRef(this);
         const domId = this._domId;
         const bottomSheetOptions: BottomSheetDataOptions = {
             owner: this,
@@ -100,7 +99,7 @@ export class ViewWithBottomSheet extends ViewWithBottomSheetBase {
                         if (bottomSheetOptions.options && bottomSheetOptions.options.dismissOnBackButton === false) {
                             return true;
                         }
-
+                        const owner = that?.get();
                         if (!owner) {
                             return false;
                         }
@@ -145,13 +144,21 @@ export class ViewWithBottomSheet extends ViewWithBottomSheetBase {
                 container: android.view.ViewGroup,
                 savedInstanceState: android.os.Bundle
             ): android.view.View {
-                owner._setupAsRootView(fragment.getActivity());
-                owner.parent = Application.getRootView();
-                owner._isAddedToNativeVisualTree = true;
-                return owner.nativeViewProtected;
+                const owner = that?.get();
+                if (owner) {
+                    owner._setupAsRootView(fragment.getActivity());
+                    owner.parent = Application.getRootView();
+                    owner._isAddedToNativeVisualTree = true;
+                    return owner.nativeViewProtected;
+                }
+                return null;
             },
 
             onStart(fragment: com.nativescript.material.bottomsheet.BottomSheetDialogFragment): void {
+                const owner = that?.get();
+                if (!owner) {
+                    return;
+                }
                 const contentViewId = getId('design_bottom_sheet');
                 const view = fragment.getDialog().findViewById(contentViewId);
                 const transparent = bottomSheetOptions.options?.transparent === true;
@@ -195,9 +202,9 @@ export class ViewWithBottomSheet extends ViewWithBottomSheetBase {
 
                 const onChangeState = bottomSheetOptions.options?.onChangeState;
                 if (onChangeState) {
-                    const changeStateBottomSheet = new ChangeStateBottomSheet(owner);
+                    const changeStateBottomSheet = new ChangeStateBottomSheet(that);
                     behavior.addBottomSheetCallback(changeStateBottomSheet);
-                    owner._onChangeStateBottomSheetCallback(changeStateBottomSheet.getStateBottomSheetFromBottomSheetBehavior(behavior.getState()));
+                    that?.get()?._onChangeStateBottomSheetCallback(changeStateBottomSheet.getStateBottomSheetFromBottomSheetBehavior(behavior.getState()));
                 }
 
                 if (owner && !owner.isLoaded) {
@@ -224,6 +231,7 @@ export class ViewWithBottomSheet extends ViewWithBottomSheetBase {
             },
 
             onDismiss(fragment: com.nativescript.material.bottomsheet.BottomSheetDialogFragment, dialog: android.content.DialogInterface): void {
+                const owner = that?.get();
                 if (owner) {
                     owner._bottomSheetCloseIgnore = true;
                 }
@@ -232,6 +240,7 @@ export class ViewWithBottomSheet extends ViewWithBottomSheetBase {
 
             onDestroy(fragment: com.nativescript.material.bottomsheet.BottomSheetDialogFragment): void {
                 (df as any).nListener = null;
+                const owner = that?.get();
                 if (owner) {
                     owner._bottomSheetCloseIgnore = false;
                     owner._bottomSheetClosed();

src/slider/slider.android.ts

@@ -85,10 +85,12 @@ export class Slider extends View {
     initNativeView() {
         super.initNativeView();
         const nativeView = this.nativeViewProtected;
+        const that = new WeakRef(this);
         this.listener = new com.google.android.material.slider.Slider.OnChangeListener({
             onValueChange: (param0: any, value: number, fromUser: boolean) => {
-                if (fromUser) {
-                    valueProperty.nativeValueChange(this as any, value);
+                const owner = that?.get();
+                if (owner && fromUser) {
+                    valueProperty.nativeValueChange(owner, value);
                 }
             }
         });
@@ -113,8 +115,6 @@ export class Slider extends View {
             if (!this.trackBackgroundColor) {
                 this.trackBackgroundColor = null;
                 this[trackBackgroundColorProperty.setNative](null);
-            // } else {
-                // this[trackBackgroundColorProperty.setNative](this.trackBackgroundColor);
             }
         }
 

src/snackbar/snackbar.android.ts

@@ -131,18 +131,22 @@ export class SnackBar extends SnackBarBase {
             tv.setLayoutDirection(android.view.View.LAYOUT_DIRECTION_RTL);
         }
         if (resolve) {
+            const that = new WeakRef(this);
             const listener = new android.view.View.OnClickListener({
                 onClick: (args) => {
                     resolve({
                         command: SnackBarAction.ACTION,
                         reason: _getReason(1),
                         event: args
                     });
-                    if (this._snackbarCallback) {
-                        this._snackbarCallback.cb = null;
-                        this._snackbarCallback = null;
+                    const owner = that?.get();
+                    if (owner) {
+                        if (owner._snackbarCallback) {
+                            owner._snackbarCallback.cb = null;
+                            owner._snackbarCallback = null;
+                        }
+                        owner._snackbar = null;
                     }
-                    this._snackbar = null;
                 }
             });