Merge pull request #452 from nativescript-community/fix-ios-bottomsheet-close-on-tap-in-background

farfromrefug · web-flow · commit 9f538450f42b · 2023-11-14T07:44:44.000+01:00
fix(bottomSheet): ios viewController undefined on tap in background
diff --git a/demo-vue3 b/demo-vue3
@@ -1 +1 @@
-Subproject commit 04d7f35bff242bef7b9bc0996435f2d70dfe7e3d
+Subproject commit b5e8f08d68c88d79a2525a1019f33e983beb3110
diff --git a/src/bottomsheet/bottomsheet.ios.ts b/src/bottomsheet/bottomsheet.ios.ts
@@ -454,10 +454,11 @@ export class ViewWithBottomSheet extends ViewWithBottomSheetBase {
         if (this.isLoaded) {
             this.callUnloaded();
         }
+        
+        this._onDismissBottomSheetCallback && this._onDismissBottomSheetCallback();
         // it is very important to clear the viewController as N does not do it
         // and the destroy of the view from svelte could trigger a layout pass on the viewController
         this.viewController = null;
-        this._onDismissBottomSheetCallback && this._onDismissBottomSheetCallback();
     }
 }
 
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -454,10 +454,11 @@ export class ViewWithBottomSheet extends ViewWithBottomSheetBase {`
`454`	`454`	`if (this.isLoaded) {`
`455`	`455`	`this.callUnloaded();`
`456`	`456`	`}`
	`457`	`+`
	`458`	`+ this._onDismissBottomSheetCallback && this._onDismissBottomSheetCallback();`
`457`	`459`	`// it is very important to clear the viewController as N does not do it`
`458`	`460`	`// and the destroy of the view from svelte could trigger a layout pass on the viewController`
`459`	`461`	`this.viewController = null;`
`460`		`- this._onDismissBottomSheetCallback && this._onDismissBottomSheetCallback();`
`461`	`462`	`}`
`462`	`463`	`}`
`463`	`464`