Fix RAM share creation when an OU contains inactive accounts

kurtismash · kurtismash · commit 3875465deb8b · 2025-11-12T16:54:08.000Z
diff --git a/modules/service-deployment/regional.tf b/modules/service-deployment/regional.tf
@@ -50,7 +50,7 @@ module "region" {
   ram = {
     create_lag_shares  = local.create_lag_shares
     lag_share_name     = local.lag_share_name
-    target_account_ids = try(flatten(values(data.aws_organizations_organizational_unit_descendant_accounts.target_accounts)[*].accounts[*].id), [])
+    target_account_ids = try([for i in flatten(values(data.aws_organizations_organizational_unit_descendant_accounts.target_accounts)[*].accounts[*]) : i.id if i.state == "ACTIVE"], [])
   }
   stepfunctions = {
     ingest_state_machine_name          = local.ingest_state_machine_name

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ module "region" {`
`50`	`50`	`ram = {`
`51`	`51`	`create_lag_shares = local.create_lag_shares`
`52`	`52`	`lag_share_name = local.lag_share_name`
`53`		`- target_account_ids = try(flatten(values(data.aws_organizations_organizational_unit_descendant_accounts.target_accounts)[].accounts[].id), [])`
	`53`	`+ target_account_ids = try([for i in flatten(values(data.aws_organizations_organizational_unit_descendant_accounts.target_accounts)[].accounts[]) : i.id if i.state == "ACTIVE"], [])`
`54`	`54`	`}`
`55`	`55`	`stepfunctions = {`
`56`	`56`	`ingest_state_machine_name = local.ingest_state_machine_name`