Skip to content

Commit 130ecd8

Browse files
committed
[Issue 2] Make ZephyrSession exceptions more specific
1 parent 5e71658 commit 130ecd8

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

zephyr/scale/zephyr_session.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
import logging
22
from urllib.parse import urlparse, parse_qs
33

4-
from requests import Session
4+
from requests import HTTPError, Session
55

66

77
INIT_SESSION_MSG = "Initialize session by {}"
88

99

10+
class InvalidAuthData(Exception):
11+
"""Invalid authentication data provided"""
12+
13+
1014
class ZephyrSession:
1115
"""
1216
Zephyr Scale basic session object.
@@ -35,7 +39,7 @@ def __init__(self, base_url, token=None, username=None, password=None, cookies=N
3539
self.logger.debug(INIT_SESSION_MSG.format("cookies"))
3640
self._session.cookies.update(cookies)
3741
else:
38-
raise Exception("Insufficient auth data")
42+
raise InvalidAuthData("Insufficient auth data")
3943

4044
if kwargs.get("session_attrs"):
4145
self._modify_session(**kwargs.get("session_attrs"))
@@ -62,7 +66,7 @@ def _request(self, method: str, endpoint: str, return_raw: bool = False, **kwarg
6266
if response.text:
6367
return response.json()
6468
return ""
65-
raise Exception(f"Error {response.status_code}. Response: {response.content}")
69+
raise HTTPError(f"Error {response.status_code}. Response: {response.content}")
6670

6771
def get(self, endpoint: str, params: dict = None, **kwargs):
6872
"""Get request wrapper"""

0 commit comments

Comments
 (0)