adding static code analyzer flake8

Author: nareshnavinash

.flake8

@@ -0,0 +1,6 @@
+[flake8]
+max_complexity = 10
+max-line-length = 120
+statistics = True
+count = True
+ignore = W191,E117

Library/driver.py

@@ -23,7 +23,8 @@ def __init__(self) -> None:
                 options.add_argument("--headless")
             self.driver = webdriver.Chrome(options=options)
             self.driver.implicitly_wait(int(Var.glob("implicit_wait")))
-            self.driver.set_window_size(int(Var.glob("browser_horizontal_size")), int(Var.glob("browser_vertical_size")))
+            self.driver.set_window_size(int(Var.glob("browser_horizontal_size")),
+                                        int(Var.glob("browser_vertical_size")))
         elif browser == "firefox":
             self.driver = webdriver.Firefox()
         elif browser == "safari":
@@ -60,4 +61,3 @@ def current_url(self) -> str:
 
     def quit(self):
         self.driver.quit()
-

Library/locator.py

@@ -96,6 +96,7 @@ def click_if_displayed(self) -> bool:
         try:
             self.is_displayed_with_wait()
             var = Store.current_driver.find_element(self.by, self.value).click
+            print("Click action complete on:" + self.by + "with " + self.value + "return value: " + var)
         except Exception as e:
             print("click if displayed not worked at \n" + self.by + "\n" + self.value + "\n Exception: \n" + str(e))
             return False
@@ -119,7 +120,7 @@ def scroll_to_locator_using_js(self) -> bool:
             scroll_locator = Store.current_driver.find_element(self.by, self.value)
             Store.current_driver.execute_script('arguments[0].scrollIntoView(true);', scroll_locator)
         except Exception as e:
-            print("scroll to locator using js not worked at \n" + self.by + "\n" + self.value + "\n Exception: \n" + str(e))
+            print("scroll to locator using js not worked at:" + self.by + ":" + self.value + " Exception: " + str(e))
             return False
         else:
             return True
@@ -139,11 +140,12 @@ def get_element(self) -> webelement.WebElement:
         try:
             return Store.current_driver.find_element(self.by, self.value)
         except Exception as e:
-            print("scroll to locator using js not worked at \n" + self.by + "\n" + self.value + "\n Exception: \n" + str(e))
+            print("get element not worked at \n" + self.by + "\n" + self.value + "\n Exception: \n" + str(e))
 
     def clear_and_send_keys(self, string) -> bool:
         try:
             var = Store.current_driver.find_element(self.by, self.value).clear
+            print("Clear action completed on: " + self.by + " and " + self.value + " Return value is: " + var)
             Store.current_driver.find_element(self.by, self.value).send_keys(string)
         except Exception as e:
             print("Clear and Send keys not worked at \n" + self.by + "\n" + self.value + "\n Exception: \n" + str(e))

Library/store.py

@@ -1,5 +1,4 @@
 from selenium import webdriver
-from selenium.webdriver.chrome.webdriver import WebDriver
 
 
 class Store:

Library/variable.py

@@ -66,6 +66,7 @@ def write(self, params):
         if self.env("snap") == "1":
             with open(self.file_path, 'w') as file:
                 documents = yaml.dump(params, file)
+                print(documents)
 
     def dynamic_value_for(self, string) -> str:
         try:

Locators/google.py

@@ -1,4 +1,3 @@
-from selenium.webdriver.common.by import By
 from Library.locator import Locator
 
 

Tests/google.py

@@ -1,6 +1,4 @@
-import pytest
 import allure
-import os
 from Library.driver import Driver
 from Pages.google import GooglePage
 from Library.variable import Var
@@ -20,7 +18,7 @@ def test_google_search():
         print("landed in google home page")
 
     with allure.step("second step"):
-        assert (GooglePage.is_search_box_displayed() == True)
+        assert (GooglePage.is_search_box_displayed() is True)
         GooglePage.enter_search_text(variable.local_value_for("search_text"))
         dynamic_data["search_text"] = GooglePage.get_search_text()
         dynamic_data["name"] = GooglePage.search_box.get_attribute("name")

requirements.txt

@@ -8,4 +8,5 @@ pytest-xdist==1.31.0
 lxml==4.4.2
 allure-pytest==2.8.6
 ipdb == 0.12.3
-pyyaml == 5.3
+pyyaml == 5.3
+flake8 == 3.7.9