Bump jshint from 2.11.1 to 2.11.2 (#30)

dependabot-preview[bot] · namoscato · web-flow · commit a841d1a66cbb · 2020-08-01T12:39:45.000-04:00
Co-authored-by: dependabot-preview[bot] &lt;27856297+dependabot-preview[bot]@users.noreply.github.com&gt;
Co-authored-by: Nick Amoscato &lt;nick@amoscato.com&gt;
diff --git a/.github/workflows/js.yaml b/.github/workflows/js.yaml
@@ -1,10 +1,10 @@
-name: test
+name: js
 on:
   pull_request:
   push:
     branches: [master]
 jobs:
-  js:
+  test:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
@@ -20,3 +20,19 @@ jobs:
         run: npm ci
       - name: Test JavaScript
         run: npm test
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Read .nvmrc
+        run: echo ::set-output name=NVMRC::$(cat .nvmrc)
+        id: nvm
+      - name: Use Node.js ${{ steps.nvm.outputs.NVMRC }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: '${{ steps.nvm.outputs.NVMRC }}'
+      - name: Install dependencies
+        run: npm ci
+      - name: Lint JavaScript
+        run: npx gulp js:lint
diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
diff --git a/.idea/jsLibraryMappings.xml b/.idea/jsLibraryMappings.xml
diff --git a/.idea/jsLinters/jshint.xml b/.idea/jsLinters/jshint.xml
diff --git a/.jshintrc b/.jshintrc
@@ -0,0 +1,3 @@
+{
+    "node": true
+}
diff --git a/dist/multiselect.js b/dist/multiselect.js
@@ -515,7 +515,7 @@
 
         /**
          * @name AmoMultiselectFactory#_optionsRegularExpression
-         * 
+         *
          * @description
          * Options attribute value regular expression
          *
diff --git a/gulpfile.js b/gulpfile.js
@@ -51,7 +51,6 @@ gulp.task('all', 'Build application', [
     'css:app',
     'js:app',
     'js:libs',
-    'js:lint'
 ]);
 
 gulp.task('dist', 'Build multiselect', [
@@ -108,9 +107,13 @@ gulp.task('js:libs', 'Compile third party JavaScript', function() {
 });
 
 gulp.task('js:lint', 'Run JSHint to check for JavaScript code quality', function() {
-    gulp.src(js.src.app)
+    gulp.src(js.src.app.concat([
+        '*.js',
+        'tests/**/*.js'
+    ]))
         .pipe(gulpJshint())
-        .pipe(gulpJshint.reporter('default'));
+        .pipe(gulpJshint.reporter('default'))
+        .pipe(gulpJshint.reporter('fail'));
 });
 
 gulp.task('serve', 'Run a local webserver', function() {
diff --git a/karma.conf.js b/karma.conf.js
@@ -15,5 +15,5 @@ module.exports = function(config) {
     autoWatch: true,
     browsers: ['ChromeHeadless'],
     singleRun: false
-  })
-}
+  });
+};
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/lib/multiselect.factory.js b/src/lib/multiselect.factory.js
@@ -15,7 +15,7 @@
 
         /**
          * @name AmoMultiselectFactory#_optionsRegularExpression
-         * 
+         *
          * @description
          * Options attribute value regular expression
          *
diff --git a/tests/lib/multiselect.directive.spec.js b/tests/lib/multiselect.directive.spec.js
@@ -69,11 +69,11 @@ describe('amoMultiselect', function() {
         amoMultiselectFactoryInstanceSpy.getOptionsExpression.and.returnValue('options');
 
         amoMultiselectFactoryInstanceSpy.getLabel.and.callFake(function(option) {
-            return 'LABEL ' + option
+            return 'LABEL ' + option;
         });
 
         amoMultiselectFactoryInstanceSpy.getValue.and.callFake(function(option) {
-            return 'VALUE ' + option
+            return 'VALUE ' + option;
         });
     });
 
diff --git a/tests/lib/multiselect.factory.spec.js b/tests/lib/multiselect.factory.spec.js
@@ -314,7 +314,7 @@ describe('AmoMultiselectFactory', function() {
                     expect(result).toEqual({
                         key: 2,
                         group: 'A'
-                    })
+                    });
                 });
             });
 
@@ -327,7 +327,7 @@ describe('AmoMultiselectFactory', function() {
                     expect(result).toEqual({
                         key: 1,
                         group: 'B'
-                    })
+                    });
                 });
             });
 
@@ -340,7 +340,7 @@ describe('AmoMultiselectFactory', function() {
                     expect(result).toEqual({
                         key: 3,
                         group: 'B'
-                    })
+                    });
                 });
             });
         });

Original file line number	Diff line number	Diff line change
`@@ -515,7 +515,7 @@`
`515`	`515`
`516`	`516`	`/**`
`517`	`517`	`* @name AmoMultiselectFactory#_optionsRegularExpression`
`518`		`- *`
	`518`	`+ *`
`519`	`519`	`* @description`
`520`	`520`	`* Options attribute value regular expression`
`521`	`521`	`*`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`
`16`	`16`	`/**`
`17`	`17`	`* @name AmoMultiselectFactory#_optionsRegularExpression`
`18`		`- *`
	`18`	`+ *`
`19`	`19`	`* @description`
`20`	`20`	`* Options attribute value regular expression`
`21`	`21`	`*`