fix: refund target signing and empty memo (#2346)

Author: mateuszjasiuk

apps/extension/src/background/keyring/keyring.ts

@@ -801,7 +801,11 @@ export class KeyRing {
 
     let privateKey: string;
 
-    if (account.public.type === AccountType.PrivateKey) {
+    if (
+      [AccountType.PrivateKey, AccountType.Disposable].includes(
+        account.public.type
+      )
+    ) {
       privateKey = secret;
     } else {
       const sdk = this.sdkService.getSdk();

apps/namadillo/src/App/Masp/MaspShield.tsx

@@ -35,7 +35,7 @@ export const MaspShield = ({
   setAssetSelectorModalOpen,
 }: MaspShieldProps): JSX.Element => {
   //  COMPONENT STATE
-  const [memo, setMemo] = useState("");
+  const [memo, setMemo] = useState<string | undefined>();
   const [displayAmount, setDisplayAmount] = useAtom(transferAmountAtom);
   const [selectedAssetWithAmount, setSelectedAssetWithAmount] = useState<
     AssetWithAmountAndChain | undefined

apps/namadillo/src/App/Masp/MaspUnshield.tsx

@@ -34,7 +34,7 @@ export const MaspUnshield = ({
   setAssetSelectorModalOpen,
 }: MaspUnshieldProps): JSX.Element => {
   //  COMPONENT STATE
-  const [memo, setMemo] = useState("");
+  const [memo, setMemo] = useState<string | undefined>();
   const [displayAmount, setDisplayAmount] = useAtom(transferAmountAtom);
   const [selectedAssetWithAmount, setSelectedAssetWithAmount] = useState<
     AssetWithAmountAndChain | undefined

apps/namadillo/src/App/NamadaTransfer/NamadaTransfer.tsx

@@ -42,7 +42,7 @@ export const NamadaTransfer = ({
   //  COMPONENT STATE
   const [displayAmount, setDisplayAmount] = useAtom(transferAmountAtom);
   const [customAddress] = useState<string>("");
-  const [memo, setMemo] = useState<string>("");
+  const [memo, setMemo] = useState<string | undefined>();
   const [selectedAssetWithAmount, setSelectedAssetWithAmount] = useState<
     AssetWithAmountAndChain | undefined
   >();

apps/namadillo/src/App/Transfer/types.ts

@@ -44,7 +44,7 @@ export type TransferModuleProps = {
     isShieldedAddress: boolean;
     memo?: string;
     onChangeAddress: (address?: string) => void;
-    onChangeMemo?: Dispatch<SetStateAction<string>>;
+    onChangeMemo?: Dispatch<SetStateAction<string | undefined>>;
   };
   requiresIbcChannels?: boolean;
   feeProps?: TransactionFeeProps;